@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Rename some internal "Autoclose" mentions to "Permanent Refs"
Summary: Depends on D20428. Ref T13277.
Test Plan: Grep / reading.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T13277
Differential Revision: https://secure.phabricator.com/D20432
+12
-12
+2
-2
src/__phutil_library_map__.php
+2
-2
src/__phutil_library_map__.php
···
4321
4321
'PhabricatorRepository' => 'applications/repository/storage/PhabricatorRepository.php',
4322
4322
'PhabricatorRepositoryActivateTransaction' => 'applications/repository/xaction/PhabricatorRepositoryActivateTransaction.php',
4323
4323
'PhabricatorRepositoryAuditRequest' => 'applications/repository/storage/PhabricatorRepositoryAuditRequest.php',
4324
-
'PhabricatorRepositoryAutocloseOnlyTransaction' => 'applications/repository/xaction/PhabricatorRepositoryAutocloseOnlyTransaction.php',
4325
4324
'PhabricatorRepositoryBlueprintsTransaction' => 'applications/repository/xaction/PhabricatorRepositoryBlueprintsTransaction.php',
4326
4325
'PhabricatorRepositoryBranch' => 'applications/repository/storage/PhabricatorRepositoryBranch.php',
4327
4326
'PhabricatorRepositoryCallsignTransaction' => 'applications/repository/xaction/PhabricatorRepositoryCallsignTransaction.php',
···
4397
4396
'PhabricatorRepositoryNotifyTransaction' => 'applications/repository/xaction/PhabricatorRepositoryNotifyTransaction.php',
4398
4397
'PhabricatorRepositoryOldRef' => 'applications/repository/storage/PhabricatorRepositoryOldRef.php',
4399
4398
'PhabricatorRepositoryParsedChange' => 'applications/repository/data/PhabricatorRepositoryParsedChange.php',
4399
+
'PhabricatorRepositoryPermanentRefsTransaction' => 'applications/repository/xaction/PhabricatorRepositoryPermanentRefsTransaction.php',
4400
4400
'PhabricatorRepositoryPullEngine' => 'applications/repository/engine/PhabricatorRepositoryPullEngine.php',
4401
4401
'PhabricatorRepositoryPullEvent' => 'applications/repository/storage/PhabricatorRepositoryPullEvent.php',
4402
4402
'PhabricatorRepositoryPullEventPHIDType' => 'applications/repository/phid/PhabricatorRepositoryPullEventPHIDType.php',
···
10553
10553
'PhabricatorRepositoryDAO',
10554
10554
'PhabricatorPolicyInterface',
10555
10555
),
10556
-
'PhabricatorRepositoryAutocloseOnlyTransaction' => 'PhabricatorRepositoryTransactionType',
10557
10556
'PhabricatorRepositoryBlueprintsTransaction' => 'PhabricatorRepositoryTransactionType',
10558
10557
'PhabricatorRepositoryBranch' => 'PhabricatorRepositoryDAO',
10559
10558
'PhabricatorRepositoryCallsignTransaction' => 'PhabricatorRepositoryTransactionType',
···
10661
10660
'PhabricatorPolicyInterface',
10662
10661
),
10663
10662
'PhabricatorRepositoryParsedChange' => 'Phobject',
10663
+
'PhabricatorRepositoryPermanentRefsTransaction' => 'PhabricatorRepositoryTransactionType',
10664
10664
'PhabricatorRepositoryPullEngine' => 'PhabricatorRepositoryEngine',
10665
10665
'PhabricatorRepositoryPullEvent' => array(
10666
10666
'PhabricatorRepositoryDAO',
+2
-2
src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php
+2
-2
src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php
···
214
214
215
215
$fetch_value = $object->getFetchRules();
216
216
$track_value = $object->getTrackOnlyRules();
217
-
$permanent_value = $object->getAutocloseOnlyRules();
217
+
$permanent_value = $object->getPermanentRefRules();
218
218
219
219
$automation_instructions = pht(
220
220
"Configure **Repository Automation** to allow Phabricator to ".
···
392
392
->setKey('permanentRefs')
393
393
->setLabel(pht('Permanent Refs'))
394
394
->setTransactionType(
395
-
PhabricatorRepositoryAutocloseOnlyTransaction::TRANSACTIONTYPE)
395
+
PhabricatorRepositoryPermanentRefsTransaction::TRANSACTIONTYPE)
396
396
->setIsCopyable(true)
397
397
->setDescription(pht('Only these refs are considered permanent.'))
398
398
->setConduitDescription(pht('Set the permanent refs.'))
+2
-2
src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php
+2
-2
src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php
···
24
24
$has_any =
25
25
$repository->getDetail('default-branch') ||
26
26
$repository->getTrackOnlyRules() ||
27
-
$repository->getAutocloseOnlyRules();
27
+
$repository->getPermanentRefRules();
28
28
29
29
if ($has_any) {
30
30
return 'fa-code-fork';
···
102
102
$permanent_display =
103
103
phutil_tag('em', array(), pht('Publishing Disabled'));
104
104
} else {
105
-
$permanent_rules = $repository->getAutocloseOnlyRules();
105
+
$permanent_rules = $repository->getPermanentRefRules();
106
106
if ($permanent_rules) {
107
107
$permanent_display = implode(', ', $permanent_rules);
108
108
} else {
+3
-3
src/applications/repository/storage/PhabricatorRepository.php
+3
-3
src/applications/repository/storage/PhabricatorRepository.php
···
1197
1197
return null;
1198
1198
}
1199
1199
1200
-
public function getAutocloseOnlyRules() {
1200
+
public function getPermanentRefRules() {
1201
1201
return array_keys($this->getDetail('close-commits-filter', array()));
1202
1202
}
1203
1203
1204
-
public function setAutocloseOnlyRules(array $rules) {
1204
+
public function setPermanentRefRules(array $rules) {
1205
1205
$rules = array_fill_keys($rules, true);
1206
1206
$this->setDetail('close-commits-filter', $rules);
1207
1207
return $this;
···
2846
2846
public function getFieldValuesForConduit() {
2847
2847
$fetch_rules = $this->getFetchRules();
2848
2848
$track_rules = $this->getTrackOnlyRules();
2849
-
$permanent_rules = $this->getAutocloseOnlyRules();
2849
+
$permanent_rules = $this->getPermanentRefRules();
2850
2850
2851
2851
$fetch_rules = $this->getStringListForConduit($fetch_rules);
2852
2852
$track_rules = $this->getStringListForConduit($track_rules);
+3
-3
src/applications/repository/xaction/PhabricatorRepositoryAutocloseOnlyTransaction.php
src/applications/repository/xaction/PhabricatorRepositoryPermanentRefsTransaction.php
+3
-3
src/applications/repository/xaction/PhabricatorRepositoryAutocloseOnlyTransaction.php
src/applications/repository/xaction/PhabricatorRepositoryPermanentRefsTransaction.php
···
1
1
<?php
2
2
3
-
final class PhabricatorRepositoryAutocloseOnlyTransaction
3
+
final class PhabricatorRepositoryPermanentRefsTransaction
4
4
extends PhabricatorRepositoryTransactionType {
5
5
6
6
const TRANSACTIONTYPE = 'repo:autoclose-only';
7
7
8
8
public function generateOldValue($object) {
9
-
return $object->getAutocloseOnlyRules();
9
+
return $object->getPermanentRefRules();
10
10
}
11
11
12
12
public function applyInternalEffects($object, $value) {
13
-
$object->setAutocloseOnlyRules($value);
13
+
$object->setPermanentRefRules($value);
14
14
}
15
15
16
16
public function getTitle() {