@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix a bug on Calendar event day views for all day events in certain timezones
Summary:
Ref T11816. This logic was correct, we just did all the work and then mostly threw away the results. This worked correctly anyway in some timezones.
Instead, actually use `$min_date` and `$max_date`.
Test Plan: In "America/Toronto" with server in a more-western timezone, viewed a "Nov 11 - Nov 12" all-day event, saw those dates.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T11816
Differential Revision: https://secure.phabricator.com/D16867
+5
-5
+5
-5
src/applications/calendar/storage/PhabricatorCalendarEvent.php
+5
-5
src/applications/calendar/storage/PhabricatorCalendarEvent.php
···
590
590
$start = $this->newStartDateTime();
591
591
$end = $this->newEndDateTime();
592
592
593
-
if ($show_end) {
594
-
$min_date = $start->newPHPDateTime();
595
-
$max_date = $end->newPHPDateTime();
593
+
$min_date = $start->newPHPDateTime();
594
+
$max_date = $end->newPHPDateTime();
596
595
596
+
if ($show_end) {
597
597
// Subtract one second since the stored date is exclusive.
598
598
$max_date = $max_date->modify('-1 second');
599
599
···
605
605
$show_end_date = false;
606
606
}
607
607
608
-
$min_epoch = $start->getEpoch();
609
-
$max_epoch = $end->getEpoch();
608
+
$min_epoch = $min_date->format('U');
609
+
$max_epoch = $max_date->format('U');
610
610
611
611
if ($this->getIsAllDay()) {
612
612
if ($show_end_date) {