recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Set a URI on Auth Messages, so the "Change Details" dialog from the transaction record has a cancel button

Summary:
If you edit an auth message in Auth > Customize Messages, then click "Show Details" in the transaction record, the resulting dialog uses the object's handle's URI to generate a "cancel" button.

Since these handles currently have no URI, the dialog currently has no cancel/done button to close it.

Test Plan: Edited an auth message, clicked "Show Details", was now able to click "Done" to close the dialog.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20471

epriestley 648d5ce1 6d13b9fb

+5 -1
+5 -1
src/applications/auth/phid/PhabricatorAuthMessagePHIDType.php
··· 28 28 PhabricatorHandleQuery $query, 29 29 array $handles, 30 30 array $objects) { 31 - return; 31 + 32 + foreach ($handles as $phid => $handle) { 33 + $message = $objects[$phid]; 34 + $handle->setURI($message->getURI()); 35 + } 32 36 } 33 37 34 38 }