@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Adding hovercard support for object tags
Summary: Refs T1048 - Adds sigil and metadata to emitted tags.
Test Plan: Inspected HTML, verified sigil and meta data reference. Hooked up behaviours in a future broken diff. Could successfully load hovercards from endpoint. I'm bad with JS though.
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Maniphest Tasks: T1048
Differential Revision: https://secure.phabricator.com/D5558
+22
-7
+22
-7
src/view/layout/PhabricatorTagView.php
+22
-7
src/view/layout/PhabricatorTagView.php
···
129
129
$bar = null;
130
130
}
131
131
132
-
return phutil_tag(
133
-
$this->href ? 'a' : 'span',
134
-
array(
135
-
'href' => $this->href,
136
-
'class' => implode(' ', $classes),
137
-
),
138
-
array($bar, $content));
132
+
if ($this->phid) {
133
+
134
+
return javelin_tag(
135
+
'a',
136
+
array(
137
+
'href' => $this->href,
138
+
'class' => implode(' ', $classes),
139
+
'sigil' => 'hovercard',
140
+
'meta' => array(
141
+
'hoverPHID' => $this->phid,
142
+
),
143
+
),
144
+
array($bar, $content));
145
+
} else {
146
+
return phutil_tag(
147
+
$this->href ? 'a' : 'span',
148
+
array(
149
+
'href' => $this->href,
150
+
'class' => implode(' ', $classes),
151
+
),
152
+
array($bar, $content));
153
+
}
139
154
}
140
155
141
156
public static function getTagTypes() {