recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Dashboard Text Panel: improve feed when changing Description

Summary:
When creating a Dashboard Text Panel, from example from here:

http://phorge.localhost/dashboard/panel/edit/?panelType=text

After you change its Description,

Before this change, this was the feed (but you must have Developer Mode):

foo.bar edited this object (transaction type "text.text").

After this change, this is the feed:

foo.bar edited the the panel text. (Show Details)

So, not only we show a nice title, but we also allow to see details.

| Before | After |
|------------|------------|
| {F2182938} | {F2182943} |

Credits:

- LegalpadDocumentTextTransaction for the getTitle() method
- ManiphestTaskDescriptionTransaction for the details

Closes T15817

Test Plan:
- Create a Text Panel from /dashboard/panel/edit/?panelType=text
- Change description
- See the new feed
- Click on "Show Details". Also that works. You see A/B changes.

Reviewers: O1 Blessed Committers, aklapper

Reviewed By: O1 Blessed Committers, aklapper

Subscribers: aklapper, tobiaswiese, Matthew, Cigaryno

Maniphest Tasks: T15817

Differential Revision: https://we.phorge.it/D25625

Valerio Bozzolan 6514598f 61c95326

+19
+19
src/applications/dashboard/xaction/panel/PhabricatorDashboardTextPanelTextTransaction.php
··· 9 9 return 'text'; 10 10 } 11 11 12 + public function getTitle() { 13 + return pht( 14 + '%s updated the panel text.', 15 + $this->renderAuthor()); 16 + } 17 + 18 + public function hasChangeDetailView() { 19 + return true; 20 + } 21 + 22 + public function newChangeDetailView() { 23 + $viewer = $this->getViewer(); 24 + 25 + return id(new PhabricatorApplicationTransactionTextDiffDetailView()) 26 + ->setViewer($viewer) 27 + ->setOldText($this->getOldValue()) 28 + ->setNewText($this->getNewValue()); 29 + } 30 + 12 31 public function newRemarkupChanges() { 13 32 $changes = array(); 14 33