@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Use unique identifier for meme hash
Summary: "a:" plus "b" and "a" plus ":b" created the same ID.
Test Plan: Created a meme.
Reviewers: DeedyDas, epriestley
Reviewed By: epriestley
CC: aran, epriestley
Differential Revision: https://secure.phabricator.com/D4631
+1
-1
+1
-1
src/applications/macro/controller/PhabricatorMacroMemeController.php
+1
-1
src/applications/macro/controller/PhabricatorMacroMemeController.php
···
20
20
21
21
$upper_text = strtoupper($upper_text);
22
22
$lower_text = strtoupper($lower_text);
23
-
$mixed_text = $upper_text.":".$lower_text;
23
+
$mixed_text = md5($upper_text).":".md5($lower_text);
24
24
$hash = "meme".hash("sha256", $mixed_text);
25
25
$xform = id(new PhabricatorTransformedFile())
26
26
->loadOneWhere('originalphid=%s and transform=%s',