recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix PHP 8.1 "strlen(null)" exception which blocks rendering a File page when Alt Text was altered

Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15342

Test Plan:
Applied these two changes on top of D25186.
Added an Alt Text to a file; page of the File now rendered correctly in web browser.
Removed Alt Text from a file; page of the File now rendered correctly in web browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15342

Differential Revision: https://we.phorge.it/D25187

Andre Klapper 651e3f72 6c692ddb

+2 -2
+2 -2
src/applications/files/xaction/PhabricatorFileAltTextTransaction.php
··· 27 27 $old_value = $this->getOldValue(); 28 28 $new_value = $this->getNewValue(); 29 29 30 - if (!strlen($old_value)) { 30 + if (!phutil_nonempty_string($old_value)) { 31 31 return pht( 32 32 '%s set the alternate text for this file to %s.', 33 33 $this->renderAuthor(), 34 34 $this->renderNewValue()); 35 - } else if (!strlen($new_value)) { 35 + } else if (!phutil_nonempty_string($new_value)) { 36 36 return pht( 37 37 '%s removed the alternate text for this file (was %s).', 38 38 $this->renderAuthor(),