@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Quicksand - fix spooky back button issue
Summary: Fixes T7911.
Test Plan:
- load a page
- click something else
- go back to original page via clicking
- browser refresh
- click something else
- browser back -- and it now works!
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T7911
Differential Revision: https://secure.phabricator.com/D12603
+8
-7
+5
-5
resources/celerity/map.php
+5
-5
resources/celerity/map.php
···
205
205
'rsrc/externals/javelin/lib/JSON.js' => '69adf288',
206
206
'rsrc/externals/javelin/lib/Leader.js' => '331b1611',
207
207
'rsrc/externals/javelin/lib/Mask.js' => '8a41885b',
208
-
'rsrc/externals/javelin/lib/Quicksand.js' => '51aeb01d',
208
+
'rsrc/externals/javelin/lib/Quicksand.js' => '7ba665f5',
209
209
'rsrc/externals/javelin/lib/Request.js' => '94b750d2',
210
210
'rsrc/externals/javelin/lib/Resource.js' => '44959b73',
211
211
'rsrc/externals/javelin/lib/Routable.js' => 'b3e7d692',
···
675
675
'javelin-leader' => '331b1611',
676
676
'javelin-magical-init' => '3010e992',
677
677
'javelin-mask' => '8a41885b',
678
-
'javelin-quicksand' => '51aeb01d',
678
+
'javelin-quicksand' => '7ba665f5',
679
679
'javelin-reactor' => '2b8de964',
680
680
'javelin-reactor-dom' => 'c90a04fc',
681
681
'javelin-reactor-node-calmer' => '76f4ebed',
···
1190
1190
'javelin-dom',
1191
1191
'javelin-reactor-dom',
1192
1192
),
1193
-
'51aeb01d' => array(
1194
-
'javelin-install',
1195
-
),
1196
1193
'54b612ba' => array(
1197
1194
'javelin-color',
1198
1195
'javelin-install',
···
1415
1412
'javelin-dom',
1416
1413
'javelin-stratcom',
1417
1414
'javelin-util',
1415
+
),
1416
+
'7ba665f5' => array(
1417
+
'javelin-install',
1418
1418
),
1419
1419
'7cbe244b' => array(
1420
1420
'javelin-install',
+3
-2
webroot/rsrc/externals/javelin/lib/Quicksand.js
+3
-2
webroot/rsrc/externals/javelin/lib/Quicksand.js
···
51
51
52
52
self._started = true;
53
53
var path = self._getRelativeURI(window.location);
54
+
self._id = window.history.state || 0;
54
55
var id = self._id;
55
56
self._history.push({path: path, id: id});
56
57
···
155
156
var id = ++self._id;
156
157
157
158
self._history.push({path: path, id: id});
158
-
JX.History.push(path, {quicksand: id});
159
+
JX.History.push(path, id);
159
160
160
161
self._cursor = (self._history.length - 1);
161
162
self._responses[id] = null;
···
262
263
var self = JX.Quicksand;
263
264
264
265
var data = e.getData();
265
-
data.state = (data.state && data.state.quicksand) || null;
266
+
data.state = data.state || null;
266
267
267
268
// Check if we're going back to the first page we started Quicksand on.
268
269
// We don't have a state value, but can look at the path.