recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix UX regression in Dashboard Tabs Panel

Summary:
Before this change, it seems that the Dashboard Tabs Panel could be empty
as default. This was the regression:

cbc0e661544a31290099ab3d88481bb8d4a3003c

The variable $is_selected was defined inside a foreach loop, but that loop
was terminated when it was then read again. This redefines that variable in
the right scope.

| Before | After |
|-----------|-----------|
| {F312797} | {F312798} |

Closes T15474

Test Plan: - see that now you have something visibile in your Dashboard Tabs Panel

Reviewers: speck, O1 Blessed Committers

Reviewed By: speck, O1 Blessed Committers

Subscribers: tobiaswiese, Matthew, Cigaryno

Maniphest Tasks: T15474, T15146

Differential Revision: https://we.phorge.it/D25291

Valerio Bozzolan 659e13fa e4fe54ed

+2
+2
src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php
··· 282 282 $panel_content = pht('(Invalid Panel)'); 283 283 } 284 284 285 + $is_selected = (string)$idx === (string)$selected; 286 + 285 287 $content_id = celerity_generate_unique_node_id(); 286 288 287 289 $content[] = phutil_tag(