@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add a borderless tag style
Summary: Formally support borderless tags in PHUITagView.
Test Plan: Used in Diffusion History List
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D18074
+29
-19
+5
-5
resources/celerity/map.php
+5
-5
resources/celerity/map.php
···
9
9
'names' => array(
10
10
'conpherence.pkg.css' => 'ff161f2d',
11
11
'conpherence.pkg.js' => 'b5b51108',
12
-
'core.pkg.css' => '8ac2e6b8',
12
+
'core.pkg.css' => '5284a0e0',
13
13
'core.pkg.js' => '1475bd91',
14
14
'darkconsole.pkg.js' => '1f9a31bc',
15
15
'differential.pkg.css' => 'a2755617',
···
71
71
'rsrc/css/application/differential/revision-history.css' => '0e8eb855',
72
72
'rsrc/css/application/differential/revision-list.css' => 'f3c47d33',
73
73
'rsrc/css/application/differential/table-of-contents.css' => 'ae4b7a55',
74
-
'rsrc/css/application/diffusion/diffusion-history.css' => 'de70e348',
74
+
'rsrc/css/application/diffusion/diffusion-history.css' => 'cc283766',
75
75
'rsrc/css/application/diffusion/diffusion-icons.css' => 'a6a1e2ba',
76
76
'rsrc/css/application/diffusion/diffusion-readme.css' => '18bd3910',
77
77
'rsrc/css/application/diffusion/diffusion-source.css' => '750add59',
···
175
175
'rsrc/css/phui/phui-segment-bar-view.css' => 'b1d1b892',
176
176
'rsrc/css/phui/phui-spacing.css' => '042804d6',
177
177
'rsrc/css/phui/phui-status.css' => 'd5263e49',
178
-
'rsrc/css/phui/phui-tag-view.css' => '3fa7765e',
178
+
'rsrc/css/phui/phui-tag-view.css' => '93b084cf',
179
179
'rsrc/css/phui/phui-timeline-view.css' => '313c7f22',
180
180
'rsrc/css/phui/phui-two-column-view.css' => 'ce9fa0b7',
181
181
'rsrc/css/phui/workboards/phui-workboard-color.css' => '783cdff5',
···
567
567
'differential-revision-history-css' => '0e8eb855',
568
568
'differential-revision-list-css' => 'f3c47d33',
569
569
'differential-table-of-contents-css' => 'ae4b7a55',
570
-
'diffusion-history-css' => 'de70e348',
570
+
'diffusion-history-css' => 'cc283766',
571
571
'diffusion-icons-css' => 'a6a1e2ba',
572
572
'diffusion-readme-css' => '18bd3910',
573
573
'diffusion-source-css' => '750add59',
···
867
867
'phui-segment-bar-view-css' => 'b1d1b892',
868
868
'phui-spacing-css' => '042804d6',
869
869
'phui-status-list-view-css' => 'd5263e49',
870
-
'phui-tag-view-css' => '3fa7765e',
870
+
'phui-tag-view-css' => '93b084cf',
871
871
'phui-theme-css' => '9f261c6b',
872
872
'phui-timeline-view-css' => '313c7f22',
873
873
'phui-two-column-view-css' => 'ce9fa0b7',
+1
src/applications/diffusion/controller/DiffusionController.php
+1
src/applications/diffusion/controller/DiffusionController.php
+2
-1
src/applications/diffusion/view/DiffusionHistoryListView.php
+2
-1
src/applications/diffusion/view/DiffusionHistoryListView.php
···
110
110
->setType(PHUITagView::TYPE_SHADE)
111
111
->setColor(PHUITagView::COLOR_BLUE)
112
112
->setHref('/D'.$d_id)
113
-
->addClass('diffusion-differential-tag')
113
+
->setBorder(PHUITagView::BORDER_NONE)
114
114
->setSlimShady(true);
115
115
}
116
116
}
···
155
155
->setName($commit_name)
156
156
->setType(PHUITagView::TYPE_SHADE)
157
157
->setColor(PHUITagView::COLOR_INDIGO)
158
+
->setBorder(PHUITagView::BORDER_NONE)
158
159
->setSlimShady(true);
159
160
160
161
$item = id(new PHUIObjectItemView())
+12
src/view/phui/PHUITagView.php
+12
src/view/phui/PHUITagView.php
···
28
28
const COLOR_OBJECT = 'object';
29
29
const COLOR_PERSON = 'person';
30
30
31
+
const BORDER_NONE = 'border-none';
32
+
31
33
private $type;
32
34
private $href;
33
35
private $name;
···
40
42
private $icon;
41
43
private $shade;
42
44
private $slimShady;
45
+
private $border;
43
46
44
47
public function setType($type) {
45
48
$this->type = $type;
···
104
107
return $this;
105
108
}
106
109
110
+
public function setBorder($border) {
111
+
$this->border = $border;
112
+
return $this;
113
+
}
114
+
107
115
public function setIcon($icon) {
108
116
$this->icon = $icon;
109
117
return $this;
···
140
148
141
149
if ($this->icon) {
142
150
$classes[] = 'phui-tag-icon-view';
151
+
}
152
+
153
+
if ($this->border) {
154
+
$classes[] = 'phui-tag-'.$this->border;
143
155
}
144
156
145
157
if ($this->phid) {
-13
webroot/rsrc/css/application/diffusion/diffusion-history.css
-13
webroot/rsrc/css/application/diffusion/diffusion-history.css
···
7
7
font-size: {$biggerfontsize};
8
8
}
9
9
10
-
.diffusion-history-list .phui-oi-attribute .phui-tag-core {
11
-
border-color: transparent;
12
-
}
13
-
14
-
.diffusion-history-list .phui-oi-attribute .phui-tag-indigo a {
15
-
color: {$indigo};
16
-
}
17
-
18
10
.diffusion-history-message {
19
11
background-color: {$bluebackground};
20
12
padding: 16px;
···
35
27
.diffusion-history-list .diffusion-differential-tag {
36
28
margin-left: 4px;
37
29
}
38
-
39
-
a.phui-tag-view:hover.diffusion-differential-tag .phui-tag-core {
40
-
border-color: transparent;
41
-
text-decoration: underline;
42
-
}
+9
webroot/rsrc/css/phui/phui-tag-view.css
+9
webroot/rsrc/css/phui/phui-tag-view.css
···
154
154
margin: 0 4px 2px 0;
155
155
}
156
156
157
+
.phui-tag-view.phui-tag-border-none .phui-tag-core {
158
+
border-color: transparent;
159
+
}
160
+
161
+
a.phui-tag-view:hover.phui-tag-border-none .phui-tag-core {
162
+
border-color: transparent !important;
163
+
text-decoration: underline;
164
+
}
165
+
157
166
158
167
/* - Shaded Tags ---------------------------------------------------------------
159
168