@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix a URI construction in remarkup macro/meme rules
Summary: Ref T13250. Some of these parameters may be NULL, and `alter()` is no longer happy about that.
Test Plan: Ran daemon tasks that happened to render some memes.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T13250
Differential Revision: https://secure.phabricator.com/D20176
+7
-4
+7
-4
src/applications/macro/engine/PhabricatorMemeEngine.php
+7
-4
src/applications/macro/engine/PhabricatorMemeEngine.php
···
47
47
}
48
48
49
49
public function getGenerateURI() {
50
-
return id(new PhutilURI('/macro/meme/'))
51
-
->alter('macro', $this->getTemplate())
52
-
->alter('above', $this->getAboveText())
53
-
->alter('below', $this->getBelowText());
50
+
$params = array(
51
+
'macro' => $this->getTemplate(),
52
+
'above' => $this->getAboveText(),
53
+
'below' => $this->getBelowText(),
54
+
);
55
+
56
+
return new PhutilURI('/macro/meme/', $params);
54
57
}
55
58
56
59
public function newAsset() {