@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix a few minor bugs in Auth Providers
Summary: Fixes T7496, T7511. Sets text for registration is not enabled, sets can_manage on add_provider button.
Test Plan: Test with a logged in admin and logged in normal joe user.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T7496, T7511
Differential Revision: https://secure.phabricator.com/D12014
+5
-2
+5
-2
src/applications/auth/controller/config/PhabricatorAuthListController.php
+5
-2
src/applications/auth/controller/config/PhabricatorAuthListController.php
···
12
12
->execute();
13
13
14
14
$list = new PHUIObjectItemListView();
15
+
$can_manage = $this->hasApplicationCapability(
16
+
AuthManageProvidersCapability::CAPABILITY);
15
17
16
18
foreach ($configs as $config) {
17
19
$item = new PHUIObjectItemView();
···
47
49
48
50
if ($config->getShouldAllowRegistration()) {
49
51
$item->addAttribute(pht('Allows Registration'));
52
+
} else {
53
+
$item->addAttribute(pht('Does Not Allow Registration'));
50
54
}
51
55
52
-
$can_manage = $this->hasApplicationCapability(
53
-
AuthManageProvidersCapability::CAPABILITY);
54
56
if ($config->getIsEnabled()) {
55
57
$item->setState(PHUIObjectItemView::STATE_SUCCESS);
56
58
$item->addAction(
···
152
154
->setColor(PHUIButtonView::SIMPLE)
153
155
->setHref($this->getApplicationURI('config/new/'))
154
156
->setIcon($image)
157
+
->setDisabled(!$can_manage)
155
158
->setText(pht('Add Provider'));
156
159
157
160
$header = id(new PHUIHeaderView())