@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix a URI construction exception when filtering the Maniphest Burnup chart by project
Summary: See <https://discourse.phabricator-community.org/t/filtering-burnup-rate-by-project-produces-exception/2442>.
Test Plan: Viewed Maniphest burnup chart, filtered by project: no more URI construction exception.
Reviewers: amckinley
Reviewed By: amckinley
Differential Revision: https://secure.phabricator.com/D20207
+11
-2
+11
-2
src/applications/maniphest/controller/ManiphestReportController.php
+11
-2
src/applications/maniphest/controller/ManiphestReportController.php
···
13
13
14
14
$project = head($request->getArr('set_project'));
15
15
$project = nonempty($project, null);
16
-
$uri = $uri->alter('project', $project);
16
+
17
+
if ($project !== null) {
18
+
$uri->replaceQueryParam('project', $project);
19
+
} else {
20
+
$uri->removeQueryParam('project');
21
+
}
17
22
18
23
$window = $request->getStr('set_window');
19
-
$uri = $uri->alter('window', $window);
24
+
if ($window !== null) {
25
+
$uri->replaceQueryParam('window', $window);
26
+
} else {
27
+
$uri->removeQueryParam('window');
28
+
}
20
29
21
30
return id(new AphrontRedirectResponse())->setURI($uri);
22
31
}