@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Make Conduit "www-form-urlencoded" parsing of "true" and "false" case-insensitive
Summary:
See PHI1710. Python encodes `True` as `True` (with an uppercase "T") when building URLs.
We currently do not accept this as a "truthy" value, but it's reasonable and unambiguous. Accept "True", "TRUE", "tRuE", etc.
Test Plan: Made a cURL conduit call with "True" and "tRuE". Before patch: failure to decoded booleans; after patch: successful interpretation of "true" variations.
Differential Revision: https://secure.phabricator.com/D21177
+3
-2
+3
-2
src/applications/conduit/parametertype/ConduitParameterType.php
+3
-2
src/applications/conduit/parametertype/ConduitParameterType.php
···
129
129
'true' => true,
130
130
);
131
131
132
-
if (!$strict && is_string($value) && isset($bool_strings[$value])) {
133
-
$value = $bool_strings[$value];
132
+
$normal_value = phutil_utf8_strtolower($value);
133
+
if (!$strict && is_string($value) && isset($bool_strings[$normal_value])) {
134
+
$value = $bool_strings[$normal_value];
134
135
} else if (!is_bool($value)) {
135
136
$this->raiseValidationException(
136
137
$request,