recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove use of deprecated E_STRICT PHP constant

Summary:
The `E_STRICT` PHP constant is deprecated since PHP 8.4 per https://www.php.net/manual/en/migration84.deprecated.php.
Per https://wiki.php.net/rfc/deprecations_php_8_4#remove_e_strict_error_level_and_deprecate_e_strict_constant, the `E_STRICT` constant was still in use in-between PHP 7.0 and 7.4 for PHP's `mysqli` extension and PHP's `htmlentities()` function.

The `E_STRICT` notice was removed from PHP's `mysqli` extension in https://github.com/php/php-src/commit/e895e962867123aff6ea703ff41670b7eb5c47f1 for PHP 7.4.0.
Since rP23a49eb403c9ea6c58f4ae2f22416e90a9d24c14, Phorge requires 7.2.25.
Phorge does not call PHP's `htmlentities()` function.

`E_STRICT` is a part of `E_ALL` since PHP 5.4.0 per https://github.com/php/php-src/blob/php-5.4.0/NEWS#L69, thus there is no gain in keeping it.

Closes T15989

Test Plan: None.

Reviewers: O1 Blessed Committers, avivey

Reviewed By: O1 Blessed Committers, avivey

Subscribers: avivey, keithzg, mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15989

Differential Revision: https://we.phorge.it/D25887

Andre Klapper 6619fef2 8d688f59

+3 -3
+1 -1
conf/__init_conf__.php
··· 45 45 } 46 46 47 47 // Make sure config file errors are reported. 48 - $old_error_level = error_reporting(E_ALL | E_STRICT); 48 + $old_error_level = error_reporting(E_ALL); 49 49 $old_display_errors = ini_get('display_errors'); 50 50 ini_set('display_errors', 1); 51 51
+1 -1
scripts/init/lib.php
··· 1 1 <?php 2 2 3 3 function init_phabricator_script(array $options) { 4 - error_reporting(E_ALL | E_STRICT); 4 + error_reporting(E_ALL); 5 5 ini_set('display_errors', 1); 6 6 7 7 $include_path = ini_get('include_path');
+1 -1
support/startup/PhabricatorStartup.php
··· 388 388 * @task validation 389 389 */ 390 390 private static function setupPHP() { 391 - error_reporting(E_ALL | E_STRICT); 391 + error_reporting(E_ALL); 392 392 self::$oldMemoryLimit = ini_get('memory_limit'); 393 393 ini_set('memory_limit', -1); 394 394