@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Use ManiphestTaskQuery instead of ad-hoc load in Maniphest reports
Summary: Fixes T5829. This stuff is old and busted, but keep it working for now.
Test Plan: No more fatal when there are recently closed tasks.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: epriestley
Maniphest Tasks: T5829
Differential Revision: https://secure.phabricator.com/D10201
+12
-3
+12
-3
src/applications/maniphest/controller/ManiphestReportController.php
+12
-3
src/applications/maniphest/controller/ManiphestReportController.php
···
671
671
$open_status_list[] = json_encode((string)$constant);
672
672
}
673
673
674
-
$tasks = queryfx_all(
674
+
$rows = queryfx_all(
675
675
$conn_r,
676
-
'SELECT t.* FROM %T t JOIN %T x ON x.objectPHID = t.phid
676
+
'SELECT t.id FROM %T t JOIN %T x ON x.objectPHID = t.phid
677
677
WHERE t.status NOT IN (%Ls)
678
678
AND x.oldValue IN (null, %Ls)
679
679
AND x.newValue NOT IN (%Ls)
···
687
687
$window_epoch,
688
688
$window_epoch);
689
689
690
-
return id(new ManiphestTask())->loadAllFromArray($tasks);
690
+
if (!$rows) {
691
+
return array();
692
+
}
693
+
694
+
$ids = ipull($rows, 'id');
695
+
696
+
return id(new ManiphestTaskQuery())
697
+
->setViewer($this->getRequest()->getUser())
698
+
->withIDs($ids)
699
+
->execute();
691
700
}
692
701
693
702
/**