@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Touch up Badges emails
Summary: Ref T12270. Adds the name of the badge to the subject, fixes the double description.
Test Plan: Edit lots of badges with and without descriptions, see good emails.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Maniphest Tasks: T12270
Differential Revision: https://secure.phabricator.com/D17449
+5
-10
+5
-10
src/applications/badges/editor/PhabricatorBadgesEditor.php
+5
-10
src/applications/badges/editor/PhabricatorBadgesEditor.php
···
87
87
protected function buildMailTemplate(PhabricatorLiskDAO $object) {
88
88
$name = $object->getName();
89
89
$id = $object->getID();
90
-
$name = pht('Badge %d', $id);
90
+
$topic = pht('Badge %d', $id);
91
+
$subject = pht('Badge %d: %s', $id, $name);
92
+
91
93
return id(new PhabricatorMetaMTAMail())
92
-
->setSubject($name)
93
-
->addHeader('Thread-Topic', $name);
94
+
->setSubject($subject)
95
+
->addHeader('Thread-Topic', $topic);
94
96
}
95
97
96
98
protected function getMailTo(PhabricatorLiskDAO $object) {
···
104
106
PhabricatorLiskDAO $object,
105
107
array $xactions) {
106
108
107
-
$description = $object->getDescription();
108
109
$body = parent::buildMailBody($object, $xactions);
109
-
110
-
if (strlen($description)) {
111
-
$body->addRemarkupSection(
112
-
pht('BADGE DESCRIPTION'),
113
-
$object->getDescription());
114
-
}
115
110
116
111
$body->addLinkSection(
117
112
pht('BADGE DETAIL'),