@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add a User-Agent header to OAuth requests
Summary: GitHub now requires this: http://developer.github.com/changes/2013-04-24-user-agent-required/
Test Plan: Used GitHub auth to login.
Reviewers: btrahan, chad
Reviewed By: chad
CC: aran
Differential Revision: https://secure.phabricator.com/D5787
+7
-6
+7
-6
src/applications/auth/controller/PhabricatorOAuthLoginController.php
+7
-6
src/applications/auth/controller/PhabricatorOAuthLoginController.php
···
47
47
$userinfo_uri = (string)$userinfo_uri;
48
48
49
49
try {
50
-
$user_data = HTTPSFuture::loadContent($userinfo_uri);
51
-
if ($user_data === false) {
52
-
throw new PhabricatorOAuthProviderException(
53
-
"Request to '{$userinfo_uri}' failed!");
54
-
}
55
-
$provider->setUserData($user_data);
50
+
$user_data_request = new HTTPSFuture($userinfo_uri);
51
+
52
+
// NOTE: GitHub requires a User-Agent header.
53
+
$user_data_request->addHeader('User-Agent', 'Phabricator');
54
+
55
+
list($body) = $user_data_request->resolvex();
56
+
$provider->setUserData($body);
56
57
} catch (PhabricatorOAuthProviderException $e) {
57
58
return $this->buildErrorResponse(new PhabricatorOAuthFailureView(), $e);
58
59
}