@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Have text-less dropdown buttons look better

Summary: Using icons and dropdown buttons without text looks a little wonky, this resets the CSS a bit.

Test Plan: Review button with icon and text, just icon, just test, and dropdowns.

Reviewers: epriestley

Reviewed By: epriestley

Spies: Korvin

Differential Revision: https://secure.phabricator.com/D18461

+15 -4
+3 -3
resources/celerity/map.php
··· 9 9 'names' => array( 10 10 'conpherence.pkg.css' => 'e68cf1fa', 11 11 'conpherence.pkg.js' => 'b5b51108', 12 - 'core.pkg.css' => 'fe4effd6', 12 + 'core.pkg.css' => 'd254d540', 13 13 'core.pkg.js' => '6c085267', 14 14 'darkconsole.pkg.js' => '1f9a31bc', 15 15 'differential.pkg.css' => '45951e9e', ··· 127 127 'rsrc/css/layout/phabricator-source-code-view.css' => 'aea41829', 128 128 'rsrc/css/phui/button/phui-button-bar.css' => 'f1ff5494', 129 129 'rsrc/css/phui/button/phui-button-simple.css' => '8e1baf68', 130 - 'rsrc/css/phui/button/phui-button.css' => '340f55c1', 130 + 'rsrc/css/phui/button/phui-button.css' => 'a37aa3a8', 131 131 'rsrc/css/phui/calendar/phui-calendar-day.css' => '572b1893', 132 132 'rsrc/css/phui/calendar/phui-calendar-list.css' => '576be600', 133 133 'rsrc/css/phui/calendar/phui-calendar-month.css' => '21154caf', ··· 824 824 'phui-big-info-view-css' => 'acc3492c', 825 825 'phui-box-css' => '745e881d', 826 826 'phui-button-bar-css' => 'f1ff5494', 827 - 'phui-button-css' => '340f55c1', 827 + 'phui-button-css' => 'a37aa3a8', 828 828 'phui-button-simple-css' => '8e1baf68', 829 829 'phui-calendar-css' => 'f1ddf11c', 830 830 'phui-calendar-day-css' => '572b1893',
+6 -1
src/applications/uiexample/examples/PHUIButtonExample.php
··· 58 58 array( 59 59 'text' => pht('Comment'), 60 60 'icon' => 'fa-comment', 61 + 'dropdown' => true, 61 62 ), 62 63 array( 63 64 'text' => pht('Give Token'), 64 65 'icon' => 'fa-trophy', 66 + 'dropdown' => true, 65 67 ), 66 68 array( 67 69 'text' => pht('Reverse Time'), ··· 73 75 ), 74 76 array( 75 77 'icon' => 'fa-rocket', 78 + 'dropdown' => true, 76 79 ), 77 80 array( 78 81 'icon' => 'fa-clipboard', 82 + 'dropdown' => true, 79 83 ), 80 84 array( 81 85 'icon' => 'fa-upload', ··· 95 99 ->setColor(PHUIButtonView::GREY) 96 100 ->setIcon(idx($spec, 'icon')) 97 101 ->setText(idx($spec, 'text')) 98 - ->addClass(PHUI::MARGIN_SMALL_RIGHT); 102 + ->addClass(PHUI::MARGIN_SMALL_RIGHT) 103 + ->setDropdown(idx($spec, 'dropdown')); 99 104 100 105 $copy = idx($spec, 'copy'); 101 106 if ($copy !== null) {
+6
webroot/rsrc/css/phui/button/phui-button.css
··· 271 271 position: relative; 272 272 } 273 273 274 + .button.has-icon.dropdown .phui-icon-view { 275 + margin-right: 8px; 276 + margin-left: -2px; 277 + } 278 + 274 279 .button.has-text .phui-icon-view { 275 280 display: inline-block; 276 281 position: absolute; 277 282 top: 7px; 278 283 left: 12px; 284 + margin: 0; 279 285 } 280 286 281 287 .button.icon-last .phui-icon-view {