@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Make icon setting in Section Headers easier/consistent
Summary: You can already pass other icons, but this makes it a bit simpler.
Test Plan: Test Maniphest, Badges
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D14131
+36
-21
+2
-1
src/applications/badges/controller/PhabricatorBadgesViewController.php
+2
-1
src/applications/badges/controller/PhabricatorBadgesViewController.php
+2
-1
src/applications/conduit/controller/PhabricatorConduitConsoleController.php
+2
-1
src/applications/conduit/controller/PhabricatorConduitConsoleController.php
···
201
201
id(new PhabricatorMarkupOneOff())->setContent($description),
202
202
'default',
203
203
$viewer);
204
-
$view->addSectionHeader(pht('Description'));
204
+
$view->addSectionHeader(
205
+
pht('Description'), PHUIPropertyListView::ICON_SUMMARY);
205
206
$view->addTextContent($description);
206
207
207
208
return $view;
+2
-1
src/applications/diffusion/controller/DiffusionBrowseController.php
+2
-1
src/applications/diffusion/controller/DiffusionBrowseController.php
···
156
156
$tag = idx($tags, $symbolic);
157
157
158
158
if ($tag && strlen($tag->getMessage())) {
159
-
$view->addSectionHeader(pht('Tag Content'));
159
+
$view->addSectionHeader(
160
+
pht('Tag Content'), 'fa-tag');
160
161
$view->addTextContent($this->markupText($tag->getMessage()));
161
162
}
162
163
}
+2
-1
src/applications/diffusion/controller/DiffusionRepositoryController.php
+2
-1
src/applications/diffusion/controller/DiffusionRepositoryController.php
+2
-1
src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php
+2
-1
src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php
···
294
294
$this->buildRepositoryUpdateInterval($repository));
295
295
296
296
$description = $repository->getDetail('description');
297
-
$view->addSectionHeader(pht('Description'));
297
+
$view->addSectionHeader(
298
+
pht('Description'), PHUIPropertyListView::ICON_SUMMARY);
298
299
if (!strlen($description)) {
299
300
$description = phutil_tag('em', array(), pht('No description provided.'));
300
301
} else {
+2
-1
src/applications/drydock/controller/DrydockLeaseViewController.php
+2
-1
src/applications/drydock/controller/DrydockLeaseViewController.php
···
121
121
122
122
$attributes = $lease->getAttributes();
123
123
if ($attributes) {
124
-
$view->addSectionHeader(pht('Attributes'));
124
+
$view->addSectionHeader(
125
+
pht('Attributes'), 'fa-list-ul');
125
126
foreach ($attributes as $key => $value) {
126
127
$view->addProperty($key, $value);
127
128
}
+2
-1
src/applications/drydock/controller/DrydockResourceViewController.php
+2
-1
src/applications/drydock/controller/DrydockResourceViewController.php
···
117
117
118
118
$attributes = $resource->getAttributes();
119
119
if ($attributes) {
120
-
$view->addSectionHeader(pht('Attributes'));
120
+
$view->addSectionHeader(
121
+
pht('Attributes'), 'fa-list-ul');
121
122
foreach ($attributes as $key => $value) {
122
123
$view->addProperty($key, $value);
123
124
}
+4
-2
src/applications/fund/controller/FundInitiativeViewController.php
+4
-2
src/applications/fund/controller/FundInitiativeViewController.php
···
103
103
'default',
104
104
$viewer);
105
105
106
-
$view->addSectionHeader(pht('Description'));
106
+
$view->addSectionHeader(
107
+
pht('Description'), PHUIPropertyListView::ICON_SUMMARY);
107
108
$view->addTextContent($description);
108
109
}
109
110
···
114
115
'default',
115
116
$viewer);
116
117
117
-
$view->addSectionHeader(pht('Risks/Challenges'));
118
+
$view->addSectionHeader(
119
+
pht('Risks/Challenges'), 'fa-ambulance');
118
120
$view->addTextContent($risks);
119
121
}
120
122
+2
-1
src/applications/harbormaster/controller/HarbormasterBuildViewController.php
+2
-1
src/applications/harbormaster/controller/HarbormasterBuildViewController.php
+2
-1
src/applications/legalpad/controller/LegalpadDocumentManageController.php
+2
-1
src/applications/legalpad/controller/LegalpadDocumentManageController.php
···
84
84
85
85
$view = new PHUIPropertyListView();
86
86
$view->addClass('legalpad');
87
-
$view->addSectionHeader(pht('Document'));
87
+
$view->addSectionHeader(
88
+
pht('Document'), 'fa-file-text-o');
88
89
$view->addTextContent(
89
90
$engine->getOutput($body, LegalpadDocumentBody::MARKUP_FIELD_TEXT));
90
91
+3
-3
src/applications/meta/controller/PhabricatorApplicationDetailViewController.php
+3
-3
src/applications/meta/controller/PhabricatorApplicationDetailViewController.php
···
106
106
$overview = $application->getOverview();
107
107
if ($overview) {
108
108
$properties->addSectionHeader(
109
-
pht('Overview'),
110
-
PHUIPropertyListView::ICON_SUMMARY);
109
+
pht('Overview'), PHUIPropertyListView::ICON_SUMMARY);
111
110
$properties->addTextContent(
112
111
PhabricatorMarkupEngine::renderOneObject(
113
112
id(new PhabricatorMarkupOneOff())->setContent($overview),
···
119
118
$viewer,
120
119
$application);
121
120
122
-
$properties->addSectionHeader(pht('Policies'));
121
+
$properties->addSectionHeader(
122
+
pht('Policies'), 'fa-lock');
123
123
124
124
foreach ($application->getCapabilities() as $capability) {
125
125
$properties->addProperty(
+2
-1
src/applications/metamta/controller/PhabricatorMetaMTAMailViewController.php
+2
-1
src/applications/metamta/controller/PhabricatorMetaMTAMailViewController.php
···
218
218
'Delivery reasons are listed from weakest to strongest.')));
219
219
}
220
220
221
-
$properties->addSectionHeader(pht('Routing Rules'));
221
+
$properties->addSectionHeader(
222
+
pht('Routing Rules'), 'fa-paper-plane-o');
222
223
223
224
$map = $mail->getDeliveredRoutingMap();
224
225
$routing_detail = null;
+2
-1
src/applications/nuance/source/NuancePhabricatorFormSourceDefinition.php
+2
-1
src/applications/nuance/source/NuancePhabricatorFormSourceDefinition.php
+2
-1
src/applications/owners/controller/PhabricatorOwnersDetailController.php
+2
-1
src/applications/owners/controller/PhabricatorOwnersDetailController.php
···
189
189
190
190
$description = $package->getDescription();
191
191
if (strlen($description)) {
192
-
$view->addSectionHeader(pht('Description'));
192
+
$view->addSectionHeader(
193
+
pht('Description'), PHUIPropertyListView::ICON_SUMMARY);
193
194
$view->addTextContent(
194
195
$output = PhabricatorMarkupEngine::renderOneObject(
195
196
id(new PhabricatorMarkupOneOff())->setContent($description),
+2
-1
src/applications/phortune/controller/PhortuneMerchantViewController.php
+2
-1
src/applications/phortune/controller/PhortuneMerchantViewController.php
+3
-3
src/view/phui/PHUIPropertyListView.php
+3
-3
src/view/phui/PHUIPropertyListView.php
···
10
10
private $classes = array();
11
11
private $stacked;
12
12
13
-
const ICON_SUMMARY = 'fa-align-left bluegrey';
14
-
const ICON_TESTPLAN = 'fa-file-text-o bluegrey';
13
+
const ICON_SUMMARY = 'fa-align-left';
14
+
const ICON_TESTPLAN = 'fa-file-text-o';
15
15
16
16
protected function canAppendChild() {
17
17
return false;
···
247
247
$name = $part['name'];
248
248
if ($part['icon']) {
249
249
$icon = id(new PHUIIconView())
250
-
->setIconFont($part['icon']);
250
+
->setIconFont($part['icon'].' bluegrey');
251
251
$name = phutil_tag(
252
252
'span',
253
253
array(