@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove spinner GIF for loading tokenizers
Summary: Ref T4420. I think the border is good enough without this spinny thing, and it needs a lot of code.
Test Plan: Used typeahead.
Reviewers: chad, btrahan
Reviewed By: chad
CC: chad, aran
Maniphest Tasks: T4420
Differential Revision: https://secure.phabricator.com/D8249
+38
-81
+38
-39
resources/celerity/map.php
+38
-39
resources/celerity/map.php
···
7
7
return array(
8
8
'names' =>
9
9
array(
10
-
'core.pkg.css' => '1ccefdc6',
11
-
'core.pkg.js' => '92f2c0a7',
10
+
'core.pkg.css' => '244a9d51',
11
+
'core.pkg.js' => '5f6c1d14',
12
12
'darkconsole.pkg.js' => 'ca8671ce',
13
13
'differential.pkg.css' => '6aef439e',
14
14
'differential.pkg.js' => '322ea941',
15
15
'diffusion.pkg.css' => '3783278d',
16
16
'diffusion.pkg.js' => '7b51e80a',
17
-
'javelin.pkg.js' => '133881a7',
17
+
'javelin.pkg.js' => 'b771965e',
18
18
'maniphest.pkg.css' => 'f1887d71',
19
19
'maniphest.pkg.js' => '1e8f11af',
20
20
'rsrc/css/aphront/aphront-bars.css' => '231ac33c',
···
36
36
'rsrc/css/aphront/tooltip.css' => '9c90229d',
37
37
'rsrc/css/aphront/transaction.css' => 'ce491938',
38
38
'rsrc/css/aphront/two-column.css' => '16ab3ad2',
39
-
'rsrc/css/aphront/typeahead.css' => 'd24b4228',
39
+
'rsrc/css/aphront/typeahead.css' => '271456a1',
40
40
'rsrc/css/application/auth/auth.css' => '1e655982',
41
41
'rsrc/css/application/base/main-menu-view.css' => 'd36e0c11',
42
42
'rsrc/css/application/base/notification-menu.css' => 'fc9a363c',
···
207
207
'rsrc/externals/javelin/lib/__tests__/URI.js' => 'ece3ddb3',
208
208
'rsrc/externals/javelin/lib/__tests__/behavior.js' => 'c1d75ee6',
209
209
'rsrc/externals/javelin/lib/behavior.js' => '8a3ed18b',
210
-
'rsrc/externals/javelin/lib/control/tokenizer/Tokenizer.js' => '1c1a6cdf',
211
-
'rsrc/externals/javelin/lib/control/typeahead/Typeahead.js' => 'caab854b',
210
+
'rsrc/externals/javelin/lib/control/tokenizer/Tokenizer.js' => 'e7c21fb3',
211
+
'rsrc/externals/javelin/lib/control/typeahead/Typeahead.js' => 'c54eeefb',
212
212
'rsrc/externals/javelin/lib/control/typeahead/normalizer/TypeaheadNormalizer.js' => '5f850b5c',
213
213
'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadCompositeSource.js' => '0136cec1',
214
214
'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadOnDemandSource.js' => '7383383f',
···
287
287
'rsrc/image/loading/loading_48.gif' => '6a4994c7',
288
288
'rsrc/image/loading/loading_d48.gif' => 'cdcbe900',
289
289
'rsrc/image/loading/loading_w24.gif' => '7662fa2b',
290
-
'rsrc/image/loading/tokenizer_loading.gif' => '93622511',
291
290
'rsrc/image/main_texture.png' => '29a2c5ad',
292
291
'rsrc/image/menu_texture.png' => '5a17580d',
293
292
'rsrc/image/people/harding.png' => '45aa614e',
···
432
431
'rsrc/js/core/KeyboardShortcutManager.js' => 'ad7a69ca',
433
432
'rsrc/js/core/MultirowRowManager.js' => 'e7076916',
434
433
'rsrc/js/core/Notification.js' => '95944043',
435
-
'rsrc/js/core/Prefab.js' => '88ca7175',
434
+
'rsrc/js/core/Prefab.js' => '0c73646e',
436
435
'rsrc/js/core/ShapedRequest.js' => 'dfa181a4',
437
436
'rsrc/js/core/TextAreaUtils.js' => 'b3ec3cfc',
438
437
'rsrc/js/core/ToolTip.js' => '0a81ea29',
···
492
491
'aphront-tokenizer-control-css' => '08ea6326',
493
492
'aphront-tooltip-css' => '9c90229d',
494
493
'aphront-two-column-view-css' => '16ab3ad2',
495
-
'aphront-typeahead-control-css' => 'd24b4228',
494
+
'aphront-typeahead-control-css' => '271456a1',
496
495
'auth-css' => '1e655982',
497
496
'config-options-css' => '7fedf08b',
498
497
'conpherence-menu-css' => '561348ac',
···
641
640
'javelin-request' => '23f9bb8d',
642
641
'javelin-resource' => '356de121',
643
642
'javelin-stratcom' => 'c293f7b9',
644
-
'javelin-tokenizer' => '1c1a6cdf',
645
-
'javelin-typeahead' => 'caab854b',
643
+
'javelin-tokenizer' => 'e7c21fb3',
644
+
'javelin-typeahead' => 'c54eeefb',
646
645
'javelin-typeahead-composite-source' => '0136cec1',
647
646
'javelin-typeahead-normalizer' => '5f850b5c',
648
647
'javelin-typeahead-ondemand-source' => '7383383f',
···
701
700
'phabricator-object-list-view-css' => '1a1ea560',
702
701
'phabricator-object-selector-css' => '029a133d',
703
702
'phabricator-phtize' => 'd254d646',
704
-
'phabricator-prefab' => '88ca7175',
703
+
'phabricator-prefab' => '0c73646e',
705
704
'phabricator-profile-css' => '3a7e04ca',
706
705
'phabricator-project-tag-css' => '095c9404',
707
706
'phabricator-remarkup-css' => 'ca7f2265',
···
860
859
1 => 'javelin-install',
861
860
2 => 'javelin-dom',
862
861
),
862
+
'0c73646e' =>
863
+
array(
864
+
0 => 'javelin-install',
865
+
1 => 'javelin-util',
866
+
2 => 'javelin-dom',
867
+
3 => 'javelin-typeahead',
868
+
4 => 'javelin-tokenizer',
869
+
5 => 'javelin-typeahead-preloaded-source',
870
+
6 => 'javelin-typeahead-ondemand-source',
871
+
7 => 'javelin-dom',
872
+
8 => 'javelin-stratcom',
873
+
9 => 'javelin-util',
874
+
),
863
875
'0e34ca02' =>
864
876
array(
865
877
0 => 'javelin-behavior',
···
916
928
4 => 'javelin-workflow',
917
929
5 => 'phabricator-draggable-list',
918
930
),
919
-
'1c1a6cdf' =>
920
-
array(
921
-
0 => 'javelin-dom',
922
-
1 => 'javelin-util',
923
-
2 => 'javelin-stratcom',
924
-
3 => 'javelin-install',
925
-
),
926
931
'1e1c8a59' =>
927
932
array(
928
933
0 => 'javelin-behavior',
···
1361
1366
6 => 'javelin-history',
1362
1367
7 => 'javelin-vector',
1363
1368
),
1364
-
'88ca7175' =>
1365
-
array(
1366
-
0 => 'javelin-install',
1367
-
1 => 'javelin-util',
1368
-
2 => 'javelin-dom',
1369
-
3 => 'javelin-typeahead',
1370
-
4 => 'javelin-tokenizer',
1371
-
5 => 'javelin-typeahead-preloaded-source',
1372
-
6 => 'javelin-typeahead-ondemand-source',
1373
-
7 => 'javelin-dom',
1374
-
8 => 'javelin-stratcom',
1375
-
9 => 'javelin-util',
1376
-
),
1377
1369
'8a3ed18b' =>
1378
1370
array(
1379
1371
0 => 'javelin-magical-init',
···
1650
1642
1 => 'javelin-stratcom',
1651
1643
2 => 'javelin-behavior',
1652
1644
),
1645
+
'c54eeefb' =>
1646
+
array(
1647
+
0 => 'javelin-install',
1648
+
1 => 'javelin-dom',
1649
+
2 => 'javelin-vector',
1650
+
3 => 'javelin-util',
1651
+
),
1653
1652
'c60f4327' =>
1654
1653
array(
1655
1654
0 => 'javelin-stratcom',
···
1682
1681
array(
1683
1682
0 => 'javelin-install',
1684
1683
1 => 'javelin-util',
1685
-
),
1686
-
'caab854b' =>
1687
-
array(
1688
-
0 => 'javelin-install',
1689
-
1 => 'javelin-dom',
1690
-
2 => 'javelin-vector',
1691
-
3 => 'javelin-util',
1692
1684
),
1693
1685
'cd9e7094' =>
1694
1686
array(
···
1829
1821
1 => 'javelin-stratcom',
1830
1822
2 => 'javelin-dom',
1831
1823
3 => 'javelin-util',
1824
+
),
1825
+
'e7c21fb3' =>
1826
+
array(
1827
+
0 => 'javelin-dom',
1828
+
1 => 'javelin-util',
1829
+
2 => 'javelin-stratcom',
1830
+
3 => 'javelin-install',
1832
1831
),
1833
1832
'e9b95df3' =>
1834
1833
array(
-14
webroot/rsrc/css/aphront/typeahead.css
-14
webroot/rsrc/css/aphront/typeahead.css
···
48
48
color: {$lightgreytext};
49
49
}
50
50
51
-
.jx-typeahead-waiting-indicator {
52
-
position: absolute;
53
-
right: 8px;
54
-
top: 2px;
55
-
width: 24px;
56
-
height: 24px;
57
-
background-image: url(/rsrc/image/loading/tokenizer_loading.gif);
58
-
display: none;
59
-
}
60
-
61
-
.jx-typeahead-waiting .jx-typeahead-waiting-indicator {
62
-
display: inline-block;
63
-
}
64
-
65
51
div.jx-tokenizer-container-focused.jx-typeahead-waiting {
66
52
border-color: {$lightblueborder};
67
53
}
-9
webroot/rsrc/externals/javelin/lib/control/tokenizer/Tokenizer.js
-9
webroot/rsrc/externals/javelin/lib/control/tokenizer/Tokenizer.js
···
36
36
JX.install('Tokenizer', {
37
37
construct : function(containerNode) {
38
38
this._containerNode = containerNode;
39
-
this._uiNodes = [];
40
39
},
41
40
42
41
events : [
···
64
63
_seq : 0,
65
64
_lastvalue : null,
66
65
_placeholder : null,
67
-
_uinodes : null,
68
66
69
67
start : function() {
70
68
if (__DEV__) {
···
126
124
this._root = root;
127
125
128
126
root.appendChild(focus);
129
-
JX.DOM.appendContent(root, this._uiNodes);
130
127
131
128
var typeahead = this._typeahead;
132
129
typeahead.setInputNode(this._focus);
···
232
229
233
230
refresh : function() {
234
231
this._redraw(true);
235
-
return this;
236
-
},
237
-
238
-
addUINode : function(node) {
239
-
this._uiNodes.push(node);
240
-
this._typeahead.addUINode(node);
241
232
return this;
242
233
},
243
234
-13
webroot/rsrc/externals/javelin/lib/control/typeahead/Typeahead.js
-13
webroot/rsrc/externals/javelin/lib/control/typeahead/Typeahead.js
···
196
196
return this;
197
197
},
198
198
199
-
/**
200
-
* Add an arbitrary node to the UI. Phabricator uses this to add a
201
-
* "waiting" graphic.
202
-
*
203
-
* @param node An arbitrary display node for the UI.
204
-
* @return this
205
-
* @task config
206
-
*/
207
-
addUINode : function(node) {
208
-
JX.DOM.appendContent(this._hardpoint, node);
209
-
return this;
210
-
},
211
-
212
199
213
200
/**
214
201
* Hide the typeahead's dropdown suggestion menu.
webroot/rsrc/image/loading/tokenizer_loading.gif
webroot/rsrc/image/loading/tokenizer_loading.gif
This is a binary file and will not be displayed.
-6
webroot/rsrc/js/core/Prefab.js
-6
webroot/rsrc/js/core/Prefab.js