@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix bug with mousein / mouseout event on comment preview at bottom of page
Summary: these comments aren't associated the same way with the actual changeset ui. ergo, don't update the reticle when mousing over these comments.
Test Plan: moused over comments at bottom - no more JS error. mouse over comments inline - reticle highlighting / de-highlighting still occurred as expected.
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Maniphest Tasks: T1657
Differential Revision: https://secure.phabricator.com/D3299
+12
-10
+12
-10
webroot/rsrc/js/application/differential/behavior-edit-inline-comments.js
+12
-10
webroot/rsrc/js/application/differential/behavior-edit-inline-comments.js
···
169
169
hideReticle();
170
170
} else {
171
171
root = e.getNode('differential-changeset');
172
+
if (root) {
172
173
173
-
var data = e.getNodeData('differential-inline-comment');
174
-
var change = e.getNodeData('differential-changeset');
174
+
var data = e.getNodeData('differential-inline-comment');
175
+
var change = e.getNodeData('differential-changeset');
175
176
176
-
var id_part = data.on_right ? change.right : change.left;
177
-
var th = e.getNode('tag:td').previousSibling;
178
-
var new_part = isNewFile(th) ? 'N' : 'O';
179
-
var prefix = 'C' + id_part + new_part + 'L';
177
+
var id_part = data.on_right ? change.right : change.left;
178
+
var th = e.getNode('tag:td').previousSibling;
179
+
var new_part = isNewFile(th) ? 'N' : 'O';
180
+
var prefix = 'C' + id_part + new_part + 'L';
180
181
181
-
origin = JX.$(prefix + data.number);
182
-
target = JX.$(prefix + (parseInt(data.number, 10) +
183
-
parseInt(data.length, 10)));
182
+
origin = JX.$(prefix + data.number);
183
+
target = JX.$(prefix + (parseInt(data.number, 10) +
184
+
parseInt(data.length, 10)));
184
185
185
-
updateReticle();
186
+
updateReticle();
187
+
}
186
188
}
187
189
});
188
190