recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix an issue with creating tasks directly into workboard columns

Summary:
See <https://discourse.phabricator-community.org/t/tasks-created-via-workboard-column-menu-are-moved-to-wrong-column/2200>. The recent `setIsConduitOnly()` / `setIsFormField()` change (in D19842) disrupted creating tasks directly into a column from the workboard UI.

This field //is// a form field, it just doesn't render a visible control.

Test Plan:
- Created a task directly into a workboard column. Before: column selection ignored. After: appeared in correct column.
- Used "move on workboard" comment action.
- Edited tasks; edited forms for tasks. Didn't observe any collateral damage (weird "Column" fields being present).

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D19870

epriestley 66ff6d4a d8e2bb9f

+3 -1
+3 -1
src/applications/maniphest/editor/ManiphestEditEngine.php
··· 169 169 ->setConduitDocumentation($column_documentation) 170 170 ->setAliases(array('columnPHID', 'columns', 'columnPHIDs')) 171 171 ->setTransactionType(PhabricatorTransactions::TYPE_COLUMNS) 172 - ->setIsFormField(false) 172 + ->setIsReorderable(false) 173 + ->setIsDefaultable(false) 174 + ->setIsLockable(false) 173 175 ->setCommentActionLabel(pht('Move on Workboard')) 174 176 ->setCommentActionOrder(2000) 175 177 ->setColumnMap($column_map),