@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
[Redesign] Misc batch of UI buggypoos
Summary:
Minor layout updates to Ref T8099
- Timeline tweaks
- Use Lato headers in Document Obj Headers
- Minor Remarkup
- Add Audit Icons
(Unclear if Audit is "correct", ie Status vs. Commit Status) But added icons anyways if needed.
Test Plan: Review each of the updated elements
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: epriestley, Korvin
Maniphest Tasks: T8099
Differential Revision: https://secure.phabricator.com/D13357
+60
-33
+9
-9
resources/celerity/map.php
+9
-9
resources/celerity/map.php
···
7
7
*/
8
8
return array(
9
9
'names' => array(
10
-
'core.pkg.css' => '96a7378c',
10
+
'core.pkg.css' => '9cbee819',
11
11
'core.pkg.js' => '41f5edc5',
12
12
'darkconsole.pkg.js' => 'e7393ebb',
13
13
'differential.pkg.css' => 'fe951924',
···
108
108
'rsrc/css/application/tokens/tokens.css' => '3d0f239e',
109
109
'rsrc/css/application/uiexample/example.css' => '528b19de',
110
110
'rsrc/css/core/core.css' => '47adcf87',
111
-
'rsrc/css/core/remarkup.css' => '13368efd',
111
+
'rsrc/css/core/remarkup.css' => '990dbed4',
112
112
'rsrc/css/core/syntax.css' => '9fd11da8',
113
113
'rsrc/css/core/z-index.css' => '63689f49',
114
114
'rsrc/css/diviner/diviner-shared.css' => '7545fd9e',
···
130
130
'rsrc/css/phui/phui-button.css' => 'f4d9c140',
131
131
'rsrc/css/phui/phui-crumbs-view.css' => 'ce840ec2',
132
132
'rsrc/css/phui/phui-document.css' => 'bc45d313',
133
-
'rsrc/css/phui/phui-feed-story.css' => '25913b7b',
134
-
'rsrc/css/phui/phui-fontkit.css' => '28739edc',
133
+
'rsrc/css/phui/phui-feed-story.css' => '1399290a',
134
+
'rsrc/css/phui/phui-fontkit.css' => '1a18fe95',
135
135
'rsrc/css/phui/phui-form-view.css' => 'a0e8f168',
136
136
'rsrc/css/phui/phui-form.css' => '17ce37a9',
137
137
'rsrc/css/phui/phui-header-view.css' => 'b9a83326',
···
150
150
'rsrc/css/phui/phui-status.css' => '888cedb8',
151
151
'rsrc/css/phui/phui-tag-view.css' => '402691cc',
152
152
'rsrc/css/phui/phui-text.css' => 'cf019f54',
153
-
'rsrc/css/phui/phui-timeline-view.css' => '07a1bd0f',
153
+
'rsrc/css/phui/phui-timeline-view.css' => 'b9d72b7f',
154
154
'rsrc/css/phui/phui-workboard-view.css' => '0cac51a4',
155
155
'rsrc/css/phui/phui-workpanel-view.css' => '4bdc2562',
156
156
'rsrc/css/sprite-login.css' => 'a3526809',
···
730
730
'phabricator-object-selector-css' => '029a133d',
731
731
'phabricator-phtize' => 'd254d646',
732
732
'phabricator-prefab' => '6920d200',
733
-
'phabricator-remarkup-css' => '13368efd',
733
+
'phabricator-remarkup-css' => '990dbed4',
734
734
'phabricator-search-results-css' => '7dea472c',
735
735
'phabricator-shaped-request' => '7cbe244b',
736
736
'phabricator-side-menu-view-css' => '4f2cd343',
···
770
770
'phui-calendar-month-css' => '476be7e0',
771
771
'phui-crumbs-view-css' => 'ce840ec2',
772
772
'phui-document-view-css' => 'bc45d313',
773
-
'phui-feed-story-css' => '25913b7b',
773
+
'phui-feed-story-css' => '1399290a',
774
774
'phui-font-icon-base-css' => '3dad2ae3',
775
-
'phui-fontkit-css' => '28739edc',
775
+
'phui-fontkit-css' => '1a18fe95',
776
776
'phui-form-css' => '17ce37a9',
777
777
'phui-form-view-css' => 'a0e8f168',
778
778
'phui-header-view-css' => 'b9a83326',
···
793
793
'phui-tag-view-css' => '402691cc',
794
794
'phui-text-css' => 'cf019f54',
795
795
'phui-theme-css' => '1ccdcc84',
796
-
'phui-timeline-view-css' => '07a1bd0f',
796
+
'phui-timeline-view-css' => 'b9d72b7f',
797
797
'phui-workboard-view-css' => '0cac51a4',
798
798
'phui-workpanel-view-css' => '4bdc2562',
799
799
'phuix-action-list-view' => 'b5c256b8',
+19
src/applications/audit/constants/PhabricatorAuditCommitStatusConstants.php
+19
src/applications/audit/constants/PhabricatorAuditCommitStatusConstants.php
···
50
50
return $color;
51
51
}
52
52
53
+
public static function getStatusIcon($code) {
54
+
switch ($code) {
55
+
case self::CONCERN_RAISED:
56
+
$icon = 'fa-exclamation-triangle';
57
+
break;
58
+
case self::NEEDS_AUDIT:
59
+
case self::PARTIALLY_AUDITED:
60
+
$icon = 'fa-exclamation-triangle';
61
+
break;
62
+
case self::FULLY_AUDITED:
63
+
$icon = 'fa-check';
64
+
break;
65
+
default:
66
+
$icon = null;
67
+
break;
68
+
}
69
+
return $icon;
70
+
}
71
+
53
72
}
+4
-1
src/applications/audit/view/PhabricatorAuditListView.php
+4
-1
src/applications/audit/view/PhabricatorAuditListView.php
···
141
141
PhabricatorAuditStatusConstants::getStatusName($status_code);
142
142
$status_color =
143
143
PhabricatorAuditStatusConstants::getStatusColor($status_code);
144
+
$status_icon =
145
+
PhabricatorAuditStatusConstants::getStatusIcon($status_code);
144
146
} else {
145
147
$reasons = null;
146
148
$status_text = null;
147
149
$status_color = null;
150
+
$status_icon = null;
148
151
}
149
152
$author_phid = $commit->getAuthorPHID();
150
153
if ($author_phid) {
···
167
170
168
171
if ($status_color) {
169
172
$item->setStatusIcon(
170
-
'fa-exclamation-triangle '.$status_color, $status_text);
173
+
$status_icon.' '.$status_color, $status_text);
171
174
}
172
175
173
176
$list->addItem($item);
+3
-4
webroot/rsrc/css/core/remarkup.css
+3
-4
webroot/rsrc/css/core/remarkup.css
···
43
43
display: block;
44
44
color: #000000;
45
45
overflow: auto;
46
-
padding: 8px;
47
-
font-family: "Monaco", monospace;
46
+
padding: 12px 8px;
48
47
}
49
48
50
49
.phabricator-remarkup pre.remarkup-counterexample {
···
159
158
}
160
159
161
160
.phabricator-remarkup blockquote {
162
-
border-left: 3px solid {$lightbluetext};
161
+
border-left: 3px solid {$sh-blueborder};
163
162
color: {$darkbluetext};
164
163
font-style: italic;
165
164
margin: 4px 0 12px 0;
166
165
padding: 8px 12px;
167
-
background-color: #F2F4F9;
166
+
background-color: {$lightbluebackground};
168
167
}
169
168
170
169
.phabricator-remarkup blockquote blockquote {
+3
-3
webroot/rsrc/css/phui/phui-feed-story.css
+3
-3
webroot/rsrc/css/phui/phui-feed-story.css
···
17
17
}
18
18
19
19
.phui-feed-story-head {
20
-
padding: 12px 8px;
20
+
padding: 12px 4px;
21
21
overflow: hidden;
22
22
color: {$greytext};
23
23
line-height: 16px;
···
29
29
}
30
30
31
31
.phui-feed-story-body {
32
-
margin: 4px 8px 8px;
32
+
margin: 4px 4px 8px;
33
33
color: {$darkgreytext};
34
34
word-break: break-word;
35
35
max-height: 300px;
···
38
38
39
39
.phui-feed-story-foot {
40
40
font-size: 12px;
41
-
padding: 8px 8px 12px 8px;
41
+
padding: 8px 4px 12px;
42
42
}
43
43
44
44
.phui-feed-story-foot,
-1
webroot/rsrc/css/phui/phui-fontkit.css
-1
webroot/rsrc/css/phui/phui-fontkit.css
+22
-15
webroot/rsrc/css/phui/phui-timeline-view.css
+22
-15
webroot/rsrc/css/phui/phui-timeline-view.css
···
25
25
.phui-timeline-major-event .phui-timeline-group {
26
26
border-left: 1px solid {$lightblueborder};
27
27
border-right: 1px solid {$lightblueborder};
28
+
border-radius: 3px;
28
29
}
29
30
30
31
.device-desktop .phui-timeline-event-view {
···
62
63
.phui-timeline-major-event .phui-timeline-content {
63
64
border-top: 1px solid {$lightblueborder};
64
65
border-bottom: 1px solid {$lightblueborder};
66
+
border-radius: 3px;
65
67
}
66
68
67
69
.phui-timeline-title {
68
-
line-height: 18px;
70
+
line-height: 22px;
69
71
min-height: 19px;
70
72
position: relative;
71
73
color: {$bluetext};
···
85
87
}
86
88
87
89
.device-desktop .phui-timeline-major-event .phui-timeline-wedge {
88
-
top: 24px;
90
+
top: 26px;
89
91
}
90
92
91
93
.device-desktop .phui-timeline-minor-event .phui-timeline-wedge {
92
-
top: 12px;
94
+
top: 13px;
93
95
left: -18px;
94
96
width: 20px;
95
97
}
96
98
97
99
.phui-timeline-image {
98
100
background-repeat: no-repeat;
99
-
background-size: 100%;
100
101
position: absolute;
101
102
border-radius: 3px;
102
103
}
···
116
117
}
117
118
118
119
.phui-timeline-major-event .phui-timeline-title {
119
-
background: {$lightgreybackground};
120
-
min-height: 18px;
120
+
background: {$lightbluebackground};
121
+
min-height: 22px;
122
+
border-top-right-radius: 3px;
123
+
}
124
+
125
+
.phui-timeline-title + .phui-timeline-title {
126
+
border-radius: 0;
121
127
}
122
128
123
129
.phui-timeline-title {
···
164
170
padding: 16px 12px;
165
171
line-height: 18px;
166
172
background: #fff;
173
+
border-bottom-left-radius: 3px;
174
+
border-bottom-right-radius: 3px;
167
175
}
168
176
169
177
.phui-timeline-core-content {
···
203
211
204
212
.phui-timeline-icon-fill {
205
213
position: absolute;
206
-
width: 30px;
207
-
height: 30px;
214
+
width: 32px;
215
+
height: 32px;
208
216
background-color: {$lightblueborder};
209
217
top: 0;
210
218
left: 0;
···
212
220
}
213
221
214
222
.phui-icon-view.phui-timeline-icon:before {
215
-
font-size: 14px;
223
+
font-size: 15px;
216
224
}
217
225
218
226
.phui-timeline-minor-event .phui-timeline-icon-fill {
219
-
height: 26px;
220
-
width: 26px;
227
+
height: 28px;
228
+
width: 28px;
221
229
border-radius: 3px;
222
230
}
223
231
224
232
.phui-timeline-icon-fill .phui-timeline-icon {
225
-
margin-top: 7px;
233
+
margin-top: 8px;
226
234
}
227
235
228
236
.phui-timeline-minor-event .phui-timeline-icon-fill .phui-timeline-icon {
229
-
margin-top: 6px;
237
+
margin-top: 7px;
230
238
}
231
239
232
240
.phui-timeline-extra,
···
238
246
239
247
.phui-timeline-title .phui-timeline-extra a {
240
248
font-weight: normal;
241
-
color: {$bluetext};
242
249
}
243
250
244
251
.device-desktop .phui-timeline-extra {
···
347
354
.phui-timeline-menu {
348
355
position: absolute;
349
356
right: 3px;
350
-
top: 4px;
357
+
top: 6px;
351
358
width: 28px;
352
359
height: 22px;
353
360
text-align: center;