+1

src/aphront/applicationconfiguration/AphrontApplicationConfiguration.php

reviewed

··· 47 47 48 48 final public function setConsole($console) { 49 49 $this->console = $console; 50 50 + return $this; 50 51 } 51 52 52 53 final public function buildController() {

+2

src/aphront/request/AphrontRequest.php

reviewed

··· 289 289 $base_domain, 290 290 $is_secure, 291 291 $http_only = true); 292 292 + 293 293 + return $this; 292 294 } 293 295 294 296 final public function setUser($user) {

+3 -1

src/applications/daemon/view/daemonlogevents/PhabricatorDaemonLogEventsView.php

reviewed

··· 1 1 <?php 2 2 3 3 /* 4 4 - * Copyright 2011 Facebook, Inc. 4 4 + * Copyright 2012 Facebook, Inc. 5 5 * 6 6 * Licensed under the Apache License, Version 2.0 (the "License"); 7 7 * you may not use this file except in compliance with the License. ··· 24 24 25 25 public function setEvents(array $events) { 26 26 $this->events = $events; 27 27 + return $this; 27 28 } 28 29 29 30 public function setCombinedLog($is_combined) { 30 31 $this->combinedLog = $is_combined; 32 32 + return $this; 31 33 } 32 34 33 35 public function setUser(PhabricatorUser $user) {

+2 -1

src/applications/daemon/view/daemonloglist/PhabricatorDaemonLogListView.php

reviewed

··· 1 1 <?php 2 2 3 3 /* 4 4 - * Copyright 2011 Facebook, Inc. 4 4 + * Copyright 2012 Facebook, Inc. 5 5 * 6 6 * Licensed under the Apache License, Version 2.0 (the "License"); 7 7 * you may not use this file except in compliance with the License. ··· 23 23 24 24 public function setDaemonLogs(array $daemon_logs) { 25 25 $this->daemonLogs = $daemon_logs; 26 26 + return $this; 26 27 } 27 28 28 29 public function setUser(PhabricatorUser $user) {

+2

src/applications/differential/view/addcomment/DifferentialAddCommentView.php

reviewed

··· 36 36 37 37 public function setActionURI($uri) { 38 38 $this->actionURI = $uri; 39 39 + return $this; 39 40 } 40 41 41 42 public function setUser(PhabricatorUser $user) { 42 43 $this->user = $user; 44 44 + return $this; 43 45 } 44 46 45 47 public function setDraft($draft) {

+1

src/applications/differential/view/inlinecomment/DifferentialInlineCommentView.php

reviewed

··· 58 58 59 59 public function setPreview($preview) { 60 60 $this->preview = $preview; 61 61 + return $this; 61 62 } 62 63 63 64 public function render() {

+1

src/applications/diffusion/query/filecontent/base/DiffusionFileContentQuery.php

reviewed

··· 109 109 110 110 public function setNeedsBlame($needs_blame) { 111 111 $this->needsBlame = $needs_blame; 112 112 + return $this; 112 113 } 113 114 114 115 public function getNeedsBlame() {

+2

src/applications/diffusion/view/emptyresult/DiffusionEmptyResultView.php

reviewed

··· 23 23 24 24 public function setBrowseQuery($browse_query) { 25 25 $this->browseQuery = $browse_query; 26 26 + return $this; 26 27 } 27 28 28 29 public function setView($view) { 29 30 $this->view = $view; 31 31 + return $this; 30 32 } 31 33 32 34 public function render() {

+6 -2

src/applications/maniphest/auxiliaryfield/base/ManiphestAuxiliaryFieldSpecification.php

reviewed

··· 31 31 32 32 public function setLabel($val) { 33 33 $this->label = $val; 34 34 + return $this; 34 35 } 35 36 36 37 public function getLabel() { ··· 39 40 40 41 public function setAuxiliaryKey($val) { 41 42 $this->auxiliaryKey = $val; 43 43 + return $this; 42 44 } 43 45 44 46 public function getAuxiliaryKey() { ··· 47 49 48 50 public function setCaption($val) { 49 51 $this->caption = $val; 52 52 + return $this; 50 53 } 51 54 52 55 public function getCaption() { ··· 55 58 56 59 public function setValue($val) { 57 60 $this->value = $val; 61 61 + return $this; 58 62 } 59 63 60 64 public function getValue() { ··· 69 73 return false; 70 74 } 71 75 72 72 - public function setType($val) 73 73 - { 76 76 + public function setType($val) { 74 77 $this->type = $val; 78 78 + return $this; 75 79 } 76 80 77 81 public function getType() {

+2 -2

src/applications/maniphest/auxiliaryfield/default/ManiphestAuxiliaryFieldDefaultSpecification.php

reviewed

··· 134 134 135 135 public function setValueFromRequest($request) { 136 136 $aux_post_values = $request->getArr('auxiliary'); 137 137 - $this->setValue(idx($aux_post_values, $this->getAuxiliaryKey(), '')); 137 137 + return $this->setValue(idx($aux_post_values, $this->getAuxiliaryKey(), '')); 138 138 } 139 139 140 140 public function getValueForStorage() { ··· 142 142 } 143 143 144 144 public function setValueFromStorage($value) { 145 145 - $this->setValue($value); 145 145 + return $this->setValue($value); 146 146 } 147 147 148 148 public function validate() {

+1

src/applications/project/editor/project/PhabricatorProjectEditor.php

reviewed

··· 157 157 default: 158 158 throw new Exception("Unknown transaction type '{$type}'!"); 159 159 } 160 160 + return $this; 160 161 } 161 162 162 163 private function applyTransactionEffect(

+2 -1

src/infrastructure/celerity/graph/CelerityResourceGraph.php

reviewed

··· 1 1 <?php 2 2 3 3 /* 4 4 - * Copyright 2011 Facebook, Inc. 4 4 + * Copyright 2012 Facebook, Inc. 5 5 * 6 6 * Licensed under the Apache License, Version 2.0 (the "License"); 7 7 * you may not use this file except in compliance with the License. ··· 39 39 final public function setResourceGraph(array $graph) { 40 40 $this->resourceGraph = $graph; 41 41 $this->graphSet = true; 42 42 + return $this; 42 43 } 43 44 44 45 private function getResourceGraph() {

+2 -1

src/infrastructure/celerity/map/CelerityResourceMap.php

reviewed

··· 1 1 <?php 2 2 3 3 /* 4 4 - * Copyright 2011 Facebook, Inc. 4 4 + * Copyright 2012 Facebook, Inc. 5 5 * 6 6 * Licensed under the Apache License, Version 2.0 (the "License"); 7 7 * you may not use this file except in compliance with the License. ··· 79 79 80 80 public function setPackageMap($package_map) { 81 81 $this->packageMap = $package_map; 82 82 + return $this; 82 83 } 83 84 84 85 public function packageResources(array $resolved_map) {

+2 -1

src/view/layout/headsup/actionlist/AphrontHeadsupActionListView.php

reviewed

··· 1 1 <?php 2 2 3 3 /* 4 4 - * Copyright 2011 Facebook, Inc. 4 4 + * Copyright 2012 Facebook, Inc. 5 5 * 6 6 * Licensed under the Apache License, Version 2.0 (the "License"); 7 7 * you may not use this file except in compliance with the License. ··· 22 22 23 23 public function setActions(array $actions) { 24 24 $this->actions = $actions; 25 25 + return $this; 25 26 } 26 27 27 28 public function render() {