@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Rename `PhabricatorSearchField` to `PhabricatorSearchFieldDocumentType`

Summary: Ref T8441. I want to use `PhabricatorSearchField` for a better, more useful object.

Test Plan: `grep`, `arc lint`

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8441

Differential Revision: https://secure.phabricator.com/D13168

+16 -15
+2 -1
src/__phutil_library_map__.php
··· 2506 2506 'PhabricatorSearchDeleteController' => 'applications/search/controller/PhabricatorSearchDeleteController.php', 2507 2507 'PhabricatorSearchDocument' => 'applications/search/storage/document/PhabricatorSearchDocument.php', 2508 2508 'PhabricatorSearchDocumentField' => 'applications/search/storage/document/PhabricatorSearchDocumentField.php', 2509 + 'PhabricatorSearchDocumentFieldType' => 'applications/search/constants/PhabricatorSearchDocumentFieldType.php', 2509 2510 'PhabricatorSearchDocumentIndexer' => 'applications/search/index/PhabricatorSearchDocumentIndexer.php', 2510 2511 'PhabricatorSearchDocumentQuery' => 'applications/search/query/PhabricatorSearchDocumentQuery.php', 2511 2512 'PhabricatorSearchDocumentRelationship' => 'applications/search/storage/document/PhabricatorSearchDocumentRelationship.php', 2512 2513 'PhabricatorSearchDocumentTypeDatasource' => 'applications/search/typeahead/PhabricatorSearchDocumentTypeDatasource.php', 2513 2514 'PhabricatorSearchEditController' => 'applications/search/controller/PhabricatorSearchEditController.php', 2514 2515 'PhabricatorSearchEngine' => 'applications/search/engine/PhabricatorSearchEngine.php', 2515 - 'PhabricatorSearchField' => 'applications/search/constants/PhabricatorSearchField.php', 2516 2516 'PhabricatorSearchHovercardController' => 'applications/search/controller/PhabricatorSearchHovercardController.php', 2517 2517 'PhabricatorSearchIndexer' => 'applications/search/index/PhabricatorSearchIndexer.php', 2518 2518 'PhabricatorSearchManagementIndexWorkflow' => 'applications/search/management/PhabricatorSearchManagementIndexWorkflow.php', ··· 5998 5998 'PhabricatorSearchDeleteController' => 'PhabricatorSearchBaseController', 5999 5999 'PhabricatorSearchDocument' => 'PhabricatorSearchDAO', 6000 6000 'PhabricatorSearchDocumentField' => 'PhabricatorSearchDAO', 6001 + 'PhabricatorSearchDocumentFieldType' => 'Phobject', 6001 6002 'PhabricatorSearchDocumentIndexer' => 'Phobject', 6002 6003 'PhabricatorSearchDocumentQuery' => 'PhabricatorCursorPagedPolicyAwareQuery', 6003 6004 'PhabricatorSearchDocumentRelationship' => 'PhabricatorSearchDAO',
+1 -1
src/applications/calendar/search/PhabricatorCalendarEventSearchIndexer.php
··· 18 18 $doc->setDocumentModified($event->getDateModified()); 19 19 20 20 $doc->addField( 21 - PhabricatorSearchField::FIELD_BODY, 21 + PhabricatorSearchDocumentFieldType::FIELD_BODY, 22 22 $event->getDescription()); 23 23 24 24 $doc->addRelationship(
+1 -1
src/applications/diviner/search/DivinerAtomSearchIndexer.php
··· 16 16 ->setDocumentModified($book->getDateModified()); 17 17 18 18 $doc->addField( 19 - PhabricatorSearchField::FIELD_BODY, 19 + PhabricatorSearchDocumentFieldType::FIELD_BODY, 20 20 $atom->getSummary()); 21 21 22 22 $doc->addRelationship(
+1 -1
src/applications/diviner/search/DivinerBookSearchIndexer.php
··· 15 15 ->setDocumentModified($book->getDateModified()); 16 16 17 17 $doc->addField( 18 - PhabricatorSearchField::FIELD_BODY, 18 + PhabricatorSearchDocumentFieldType::FIELD_BODY, 19 19 $book->getPreface()); 20 20 21 21 return $doc;
+1 -1
src/applications/maniphest/search/ManiphestSearchIndexer.php
··· 17 17 $doc->setDocumentModified($task->getDateModified()); 18 18 19 19 $doc->addField( 20 - PhabricatorSearchField::FIELD_BODY, 20 + PhabricatorSearchDocumentFieldType::FIELD_BODY, 21 21 $task->getDescription()); 22 22 23 23 $doc->addRelationship(
+1 -1
src/applications/passphrase/search/PassphraseSearchIndexer.php
··· 17 17 $doc->setDocumentModified($credential->getDateModified()); 18 18 19 19 $doc->addField( 20 - PhabricatorSearchField::FIELD_BODY, 20 + PhabricatorSearchDocumentFieldType::FIELD_BODY, 21 21 $credential->getDescription()); 22 22 23 23 $doc->addRelationship(
+1 -1
src/applications/pholio/search/PholioSearchIndexer.php
··· 15 15 ->setDocumentModified($mock->getDateModified()); 16 16 17 17 $doc->addField( 18 - PhabricatorSearchField::FIELD_BODY, 18 + PhabricatorSearchDocumentFieldType::FIELD_BODY, 19 19 $mock->getDescription()); 20 20 21 21 $doc->addRelationship(
+1 -1
src/applications/phriction/search/PhrictionSearchIndexer.php
··· 25 25 $doc->setDocumentModified($content->getDateModified()); 26 26 27 27 $doc->addField( 28 - PhabricatorSearchField::FIELD_BODY, 28 + PhabricatorSearchDocumentFieldType::FIELD_BODY, 29 29 $content->getContent()); 30 30 31 31 $doc->addRelationship(
+2 -2
src/applications/ponder/search/PonderSearchIndexer.php
··· 16 16 ->setDocumentModified($question->getDateModified()); 17 17 18 18 $doc->addField( 19 - PhabricatorSearchField::FIELD_BODY, 19 + PhabricatorSearchDocumentFieldType::FIELD_BODY, 20 20 $question->getContent()); 21 21 22 22 $doc->addRelationship( ··· 32 32 foreach ($answers as $answer) { 33 33 if (strlen($answer->getContent())) { 34 34 $doc->addField( 35 - PhabricatorSearchField::FIELD_COMMENT, 35 + PhabricatorSearchDocumentFieldType::FIELD_COMMENT, 36 36 $answer->getContent()); 37 37 } 38 38 }
+1 -1
src/applications/project/customfield/PhabricatorProjectDescriptionField.php
··· 11 11 'name' => pht('Description'), 12 12 'type' => 'remarkup', 13 13 'description' => pht('Short project description.'), 14 - 'fulltext' => PhabricatorSearchField::FIELD_BODY, 14 + 'fulltext' => PhabricatorSearchDocumentFieldType::FIELD_BODY, 15 15 ), 16 16 )); 17 17 }
+1 -1
src/applications/repository/search/PhabricatorRepositoryCommitSearchIndexer.php
··· 36 36 $doc->setDocumentTitle($title); 37 37 38 38 $doc->addField( 39 - PhabricatorSearchField::FIELD_BODY, 39 + PhabricatorSearchDocumentFieldType::FIELD_BODY, 40 40 $commit_message); 41 41 42 42 if ($author_phid) {
+1 -1
src/applications/search/constants/PhabricatorSearchField.php src/applications/search/constants/PhabricatorSearchDocumentFieldType.php
··· 1 1 <?php 2 2 3 - final class PhabricatorSearchField { 3 + final class PhabricatorSearchDocumentFieldType extends Phobject { 4 4 5 5 const FIELD_TITLE = 'titl'; 6 6 const FIELD_BODY = 'body';
+1 -1
src/applications/search/index/PhabricatorSearchAbstractDocument.php
··· 22 22 23 23 public function setDocumentTitle($title) { 24 24 $this->documentTitle = $title; 25 - $this->addField(PhabricatorSearchField::FIELD_TITLE, $title); 25 + $this->addField(PhabricatorSearchDocumentFieldType::FIELD_TITLE, $title); 26 26 return $this; 27 27 } 28 28
+1 -1
src/applications/search/index/PhabricatorSearchDocumentIndexer.php
··· 154 154 155 155 $comment = $xaction->getComment(); 156 156 $doc->addField( 157 - PhabricatorSearchField::FIELD_COMMENT, 157 + PhabricatorSearchDocumentFieldType::FIELD_COMMENT, 158 158 $comment->getContent()); 159 159 } 160 160 }