@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove dead `rejectImpossiblePolicy()` method

Summary: Ref T603. Apparently we made all policies possible at some point. Go us! This has no callsites.

Test Plan: `grep`, notice it's a private method

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D7259

-27
-27
src/applications/policy/filter/PhabricatorPolicyFilter.php
··· 233 233 return false; 234 234 } 235 235 236 - private function rejectImpossiblePolicy( 237 - PhabricatorPolicyInterface $object, 238 - $policy, 239 - $capability) { 240 - 241 - if (!$this->raisePolicyExceptions) { 242 - return; 243 - } 244 - 245 - switch ($capability) { 246 - case PhabricatorPolicyCapability::CAN_VIEW: 247 - $message = pht("This object has an impossible view policy."); 248 - break; 249 - case PhabricatorPolicyCapability::CAN_EDIT: 250 - $message = pht("This object has an impossible edit policy."); 251 - break; 252 - case PhabricatorPolicyCapability::CAN_JOIN: 253 - $message = pht("This object has an impossible join policy."); 254 - break; 255 - default: 256 - $message = pht("This object has an impossible policy."); 257 - break; 258 - } 259 - 260 - throw new PhabricatorPolicyException($message); 261 - } 262 - 263 236 public function rejectObject( 264 237 PhabricatorPolicyInterface $object, 265 238 $policy,