@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Catch exception when a renderer freaks out
Summary:
Had some cases where the Py-Notebook(?) renderer throws an exception in `can render`, blocking the entire page render.
"False" is probably the right answer if you crash here.
Test Plan: Loaded same file, saw some meta-data about the file.
Reviewers: O1 Blessed Committers, valerio.bozzolan
Reviewed By: O1 Blessed Committers, valerio.bozzolan
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Differential Revision: https://we.phorge.it/D25984
+6
-1
+6
-1
src/applications/files/document/PhabricatorDocumentEngine.php
+6
-1
src/applications/files/document/PhabricatorDocumentEngine.php
···
28
28
}
29
29
30
30
final public function canRenderDocument(PhabricatorDocumentRef $ref) {
31
-
return $this->canRenderDocumentType($ref);
31
+
try {
32
+
return $this->canRenderDocumentType($ref);
33
+
} catch (Throwable $e) {
34
+
phlog($e);
35
+
return false;
36
+
}
32
37
}
33
38
34
39
public function canDiffDocuments(