@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Use ManiphestTransactionQuery in detail view
Summary: Ref T2217. Nuke this legacy callsite.
Test Plan: Loaded a task, looked at it. Looked the same as before.
Reviewers: btrahan
Reviewed By: btrahan
CC: aran
Maniphest Tasks: T2217
Differential Revision: https://secure.phabricator.com/D7078
+7
-6
+7
-6
src/applications/maniphest/controller/ManiphestTaskDetailController.php
+7
-6
src/applications/maniphest/controller/ManiphestTaskDetailController.php
···
31
31
$parent_task = id(new ManiphestTask())->load($workflow);
32
32
}
33
33
34
-
$transactions = ManiphestLegacyTransactionQuery::loadByTask(
35
-
$user,
36
-
$task);
34
+
$transactions = id(new ManiphestTransactionQuery())
35
+
->setViewer($user)
36
+
->withObjectPHIDs(array($task->getPHID()))
37
+
->needComments(true)
38
+
->execute();
37
39
38
40
$field_list = PhabricatorCustomField::getObjectFields(
39
41
$task,
···
134
136
$engine = new PhabricatorMarkupEngine();
135
137
$engine->setViewer($user);
136
138
$engine->addObject($task, ManiphestTask::MARKUP_FIELD_DESCRIPTION);
137
-
foreach ($transactions as $xaction) {
138
-
$modern_xaction = $xaction->getModernTransaction();
139
+
foreach ($transactions as $modern_xaction) {
139
140
if ($modern_xaction->getComment()) {
140
141
$engine->addObject(
141
142
$modern_xaction->getComment(),
···
319
320
$timeline = id(new PhabricatorApplicationTransactionView())
320
321
->setUser($user)
321
322
->setObjectPHID($task->getPHID())
322
-
->setTransactions(mpull($transactions, 'getModernTransaction'))
323
+
->setTransactions($transactions)
323
324
->setMarkupEngine($engine);
324
325
325
326
$object_name = 'T'.$task->getID();