@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Allow phui-closed-tag to be readable on hover
Summary: In general these are fairly readable, but if not it cleans up on hover (and hover card).
Test Plan: tested a closed task in my sandbox
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: epriestley, Korvin
Differential Revision: https://secure.phabricator.com/D9158
+22
-9
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
7
7
return array(
8
8
'names' =>
9
9
array(
10
-
'core.pkg.css' => '7c4a7aa4',
10
+
'core.pkg.css' => '59ea1706',
11
11
'core.pkg.js' => 'b2ed04a2',
12
12
'darkconsole.pkg.js' => 'ca8671ce',
13
13
'differential.pkg.css' => '4b8686e3',
···
143
143
'rsrc/css/phui/phui-remarkup-preview.css' => '19ad512b',
144
144
'rsrc/css/phui/phui-spacing.css' => '042804d6',
145
145
'rsrc/css/phui/phui-status.css' => '2f562399',
146
-
'rsrc/css/phui/phui-tag-view.css' => '295d81c4',
146
+
'rsrc/css/phui/phui-tag-view.css' => '5d09d99e',
147
147
'rsrc/css/phui/phui-text.css' => '23e9b4b7',
148
148
'rsrc/css/phui/phui-timeline-view.css' => '15ff2a9f',
149
149
'rsrc/css/phui/phui-workboard-view.css' => '2bf82d00',
···
778
778
'phui-remarkup-preview-css' => '19ad512b',
779
779
'phui-spacing-css' => '042804d6',
780
780
'phui-status-list-view-css' => '2f562399',
781
-
'phui-tag-view-css' => '295d81c4',
781
+
'phui-tag-view-css' => '5d09d99e',
782
782
'phui-text-css' => '23e9b4b7',
783
783
'phui-timeline-view-css' => '15ff2a9f',
784
784
'phui-workboard-view-css' => '2bf82d00',
+2
src/infrastructure/markup/rule/PhabricatorRemarkupRuleObject.php
+2
src/infrastructure/markup/rule/PhabricatorRemarkupRuleObject.php
···
65
65
protected function renderObjectEmbed($object, $handle, $options) {
66
66
$name = $handle->getFullName();
67
67
$href = $handle->getURI();
68
+
$status_closed = PhabricatorObjectHandleStatus::STATUS_CLOSED;
68
69
69
70
if ($this->getEngine()->isTextMode()) {
70
71
return $name.' <'.PhabricatorEnv::getProductionURI($href).'>';
···
72
73
73
74
$attr = array(
74
75
'phid' => $handle->getPHID(),
76
+
'closed' => ($handle->getStatus() == $status_closed),
75
77
);
76
78
77
79
return $this->renderHovertag($name, $href, $attr);
+9
-4
src/view/phui/PHUITagView.php
+9
-4
src/view/phui/PHUITagView.php
···
101
101
'phui-tag-type-'.$this->type,
102
102
);
103
103
104
-
if ($this->closed) {
105
-
$classes[] = 'phui-tag-state-closed';
106
-
}
107
-
108
104
$color = null;
109
105
if ($this->backgroundColor) {
110
106
$color = 'phui-tag-color-'.$this->backgroundColor;
···
135
131
'class' => 'phui-tag-core '.$color,
136
132
),
137
133
array($dot, $this->name));
134
+
135
+
if ($this->closed) {
136
+
$content = phutil_tag(
137
+
'span',
138
+
array(
139
+
'class' => 'phui-tag-core-closed',
140
+
),
141
+
$content);
142
+
}
138
143
139
144
if ($this->phid) {
140
145
Javelin::initBehavior('phabricator-hovercards');
+8
-2
webroot/rsrc/css/phui/phui-tag-view.css
+8
-2
webroot/rsrc/css/phui/phui-tag-view.css
···
13
13
text-decoration: none;
14
14
}
15
15
16
-
.phui-tag-state-closed .phui-tag-core {
16
+
.phui-tag-core-closed {
17
17
text-decoration: line-through;
18
+
color: rgba(0,0,0,0.5);
19
+
}
20
+
21
+
.phui-tag-core-closed:hover {
22
+
text-decoration: none;
18
23
}
19
24
20
25
.phui-tag-core {
···
57
62
58
63
.phui-tag-type-object,
59
64
a.phui-tag-type-object,
60
-
a.phui-tag-type-object:link {
65
+
a.phui-tag-type-object:link,
66
+
.phui-tag-core-closed .phui-tag-color-object {
61
67
color: #000000;
62
68
}
63
69