@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix method visibilities
Summary: This should (hopefully) be the last one of these since D13185 has landed.
Test Plan: `arc unit`
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley, #blessed_reviewers
Subscribers: epriestley, Korvin
Differential Revision: https://secure.phabricator.com/D13284
+6
-6
+4
-4
src/applications/maniphest/query/ManiphestTaskSearchEngine.php
+4
-4
src/applications/maniphest/query/ManiphestTaskSearchEngine.php
···
43
43
->needProjectPHIDs(true);
44
44
}
45
45
46
-
public function buildCustomSearchFields() {
46
+
protected function buildCustomSearchFields() {
47
47
return array(
48
48
id(new PhabricatorSearchOwnersField())
49
49
->setLabel(pht('Assigned To'))
···
105
105
);
106
106
}
107
107
108
-
public function getDefaultFieldOrder() {
108
+
protected function getDefaultFieldOrder() {
109
109
return array(
110
110
'assignedPHIDs',
111
111
'projectPHIDs',
···
128
128
);
129
129
}
130
130
131
-
public function getHiddenFields() {
131
+
protected function getHiddenFields() {
132
132
$keys = array();
133
133
134
134
if ($this->getIsBoardView()) {
···
140
140
return $keys;
141
141
}
142
142
143
-
public function buildQueryFromParameters(array $map) {
143
+
protected function buildQueryFromParameters(array $map) {
144
144
$query = id(new ManiphestTaskQuery())
145
145
->needProjectPHIDs(true);
146
146
+2
-2
src/applications/spaces/query/PhabricatorSpacesNamespaceSearchEngine.php
+2
-2
src/applications/spaces/query/PhabricatorSpacesNamespaceSearchEngine.php
···
15
15
return new PhabricatorSpacesNamespaceQuery();
16
16
}
17
17
18
-
public function buildCustomSearchFields() {
18
+
protected function buildCustomSearchFields() {
19
19
return array(
20
20
id(new PhabricatorSearchThreeStateField())
21
21
->setLabel(pht('Active'))
···
27
27
);
28
28
}
29
29
30
-
public function buildQueryFromParameters(array $map) {
30
+
protected function buildQueryFromParameters(array $map) {
31
31
$query = $this->newQuery();
32
32
33
33
if ($map['active']) {