@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Added differential revision reviewers information to differential.getrevision conduit call.
Summary:
The reviewer information was not available for revisions before this.
Test Plan:
Tested with Conduit Console that correct reviewers were returned.
Reviewed By: jungejason
Reviewers: jungejason
Commenters: epriestley
CC: epriestley, tuomaspelkonen, jungejason
Differential Revision: 160
+4
+4
src/applications/conduit/method/differential/getrevision/ConduitAPI_differential_getrevision_Method.php
+4
src/applications/conduit/method/differential/getrevision/ConduitAPI_differential_getrevision_Method.php
···
47
47
throw new ConduitException('ERR_BAD_REVISION');
48
48
}
49
49
50
+
$revision->loadRelationships();
51
+
$reviewer_phids = array_values($revision->getReviewers());
52
+
50
53
$diffs = $revision->loadDiffs();
51
54
52
55
$diff_dicts = array();
···
74
77
'blameRevision' => $revision->getBlameRevision(),
75
78
'dateCommitted' => $revision->getDateCommitted(),
76
79
'lineCount' => $revision->getLineCount(),
80
+
'reviewerPHIDs' => $reviewer_phids,
77
81
'diffs' => $diff_dicts,
78
82
);
79
83