@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Set "importStatus" as nonmutable on save()

Summary: Fixes T6840. Depends on D11822, which is a little iffy.

Test Plan:
Verified all references to `importStatus` are either:

- SQL patches creating the column;
- reads;
- writes immediately before an insert; or
- explicit updates of the column.

That is, I identified no cases of `setImportStatus(X)->save()` on a Commit which may already exist. This //would// break that.

In general, almost all writes go through `$commit->writeImportStatusFlag()`, which is an explicit update.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T6840

Differential Revision: https://secure.phabricator.com/D11823

+6 -3
+3 -3
resources/celerity/map.php
··· 7 7 */ 8 8 return array( 9 9 'names' => array( 10 - 'core.pkg.css' => '048d109b', 10 + 'core.pkg.css' => '375bfcd1', 11 11 'core.pkg.js' => '23d653bb', 12 12 'darkconsole.pkg.js' => '8ab24e01', 13 13 'differential.pkg.css' => '380f07e5', ··· 104 104 'rsrc/css/application/slowvote/slowvote.css' => '266df6a1', 105 105 'rsrc/css/application/tokens/tokens.css' => '3d0f239e', 106 106 'rsrc/css/application/uiexample/example.css' => '528b19de', 107 - 'rsrc/css/core/core.css' => 'd7f6ec35', 107 + 'rsrc/css/core/core.css' => '8f9b9588', 108 108 'rsrc/css/core/remarkup.css' => 'de20f873', 109 109 'rsrc/css/core/syntax.css' => '56c1ba38', 110 110 'rsrc/css/core/z-index.css' => '40eb7003', ··· 715 715 'phabricator-busy' => '6453c869', 716 716 'phabricator-chatlog-css' => '852140ff', 717 717 'phabricator-content-source-view-css' => '4b8b05d4', 718 - 'phabricator-core-css' => 'd7f6ec35', 718 + 'phabricator-core-css' => '8f9b9588', 719 719 'phabricator-countdown-css' => '86b7b0a0', 720 720 'phabricator-dashboard-css' => 'c0062064', 721 721 'phabricator-drag-and-drop-file-upload' => '8c49f386',
+3
src/applications/repository/storage/PhabricatorRepositoryCommit.php
··· 99 99 'unique' => true, 100 100 ), 101 101 ), 102 + self::CONFIG_NO_MUTATE => array( 103 + 'importStatus', 104 + ), 102 105 ) + parent::getConfiguration(); 103 106 } 104 107