@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Spiffy up new sidebar, simplify UI

Summary: Mostly a visual spacing pass, also adds in circle icons for edit, collapse. For now removing the fixed position on the icons for simplicity while the basics are being polished.

Test Plan: Projects, Profiles, wide and narrow.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15081

+57 -83
+5 -5
resources/celerity/map.php
··· 7 7 */ 8 8 return array( 9 9 'names' => array( 10 - 'core.pkg.css' => '005bc22f', 10 + 'core.pkg.css' => 'cea85605', 11 11 'core.pkg.js' => '573e6664', 12 12 'darkconsole.pkg.js' => 'e7393ebb', 13 13 'differential.pkg.css' => '2de124c9', ··· 143 143 'rsrc/css/phui/phui-object-item-list-view.css' => '26c30d3f', 144 144 'rsrc/css/phui/phui-pager.css' => 'bea33d23', 145 145 'rsrc/css/phui/phui-pinboard-view.css' => '2495140e', 146 - 'rsrc/css/phui/phui-profile-menu.css' => '84966ae9', 146 + 'rsrc/css/phui/phui-profile-menu.css' => '2168816d', 147 147 'rsrc/css/phui/phui-property-list-view.css' => '27b2849e', 148 148 'rsrc/css/phui/phui-remarkup-preview.css' => '1a8f2591', 149 149 'rsrc/css/phui/phui-spacing.css' => '042804d6', ··· 152 152 'rsrc/css/phui/phui-text.css' => 'cf019f54', 153 153 'rsrc/css/phui/phui-timeline-view.css' => '2efceff8', 154 154 'rsrc/css/phui/phui-two-column-view.css' => '39ecafb1', 155 - 'rsrc/css/phui/phui-workboard-view.css' => '8330bca5', 155 + 'rsrc/css/phui/phui-workboard-view.css' => 'f488d036', 156 156 'rsrc/css/phui/phui-workpanel-view.css' => 'adec7699', 157 157 'rsrc/css/sprite-login.css' => '60e8560e', 158 158 'rsrc/css/sprite-menu.css' => '9dd65b92', ··· 819 819 'phui-object-item-list-view-css' => '26c30d3f', 820 820 'phui-pager-css' => 'bea33d23', 821 821 'phui-pinboard-view-css' => '2495140e', 822 - 'phui-profile-menu-css' => '84966ae9', 822 + 'phui-profile-menu-css' => '2168816d', 823 823 'phui-property-list-view-css' => '27b2849e', 824 824 'phui-remarkup-preview-css' => '1a8f2591', 825 825 'phui-spacing-css' => '042804d6', ··· 829 829 'phui-theme-css' => '981a58f8', 830 830 'phui-timeline-view-css' => '2efceff8', 831 831 'phui-two-column-view-css' => '39ecafb1', 832 - 'phui-workboard-view-css' => '8330bca5', 832 + 'phui-workboard-view-css' => 'f488d036', 833 833 'phui-workpanel-view-css' => 'adec7699', 834 834 'phuix-action-list-view' => 'b5c256b8', 835 835 'phuix-action-view' => '8cf6d262',
+4 -12
src/applications/celerity/postprocessor/CelerityDefaultPostprocessor.php
··· 191 191 // Background color for "dark" themes. 192 192 'page.background.dark' => '#ebecee', 193 193 194 - // NOTE: We can't just do these with an alpha channel because the 195 - // fixed items in the footer may render on top of other items, so the 196 - // backgrounds must be opaque. 197 - 198 194 // This is the base background color. 199 - 'menu.profile.background' => '#525868', 200 - 201 - // This is premultiplied 7.5% alpha. 202 - 'menu.profile.background.hover' => '#4c5160', 203 - 204 - // This is premultiplied 15% alpha. 205 - 'menu.profile.background.selected' => '#464b59', 195 + 'menu.profile.background' => '#525867', 196 + 'menu.profile.background.hover' => '#464b58', 197 + 'menu.profile.background.selected' => '#393d48', 206 198 207 199 'menu.profile.text' => '#c6c7cb', 208 200 'menu.profile.text.selected' => '#ffffff', ··· 211 203 'menu.main.height' => '44px', 212 204 213 205 'menu.profile.width' => '240px', 214 - 'menu.profile.width.collapsed' => '80px', 206 + 'menu.profile.width.collapsed' => '88px', 215 207 'menu.profile.item.height' => '46px', 216 208 217 209 );
+4 -4
src/applications/search/engine/PhabricatorProfilePanelEngine.php
··· 327 327 $object, 328 328 PhabricatorPolicyCapability::CAN_EDIT); 329 329 330 - $expanded_edit_icon = id(new PHUIIconView()) 330 + $expanded_edit_icon = id(new PHUIIconCircleView()) 331 331 ->addClass('phui-list-item-icon') 332 332 ->addClass('phui-profile-menu-visible-when-expanded') 333 333 ->setIconFont('fa-pencil'); 334 334 335 - $collapsed_edit_icon = id(new PHUIIconView()) 335 + $collapsed_edit_icon = id(new PHUIIconCircleView()) 336 336 ->addClass('phui-list-item-icon') 337 337 ->addClass('phui-profile-menu-visible-when-collapsed') 338 338 ->setIconFont('fa-pencil') ··· 386 386 'settingsURI' => $settings_uri, 387 387 )); 388 388 389 - $collapse_icon = id(new PHUIIconView()) 389 + $collapse_icon = id(new PHUIIconCircleView()) 390 390 ->addClass('phui-list-item-icon') 391 391 ->addClass('phui-profile-menu-visible-when-expanded') 392 392 ->setIconFont('fa-angle-left'); 393 393 394 - $expand_icon = id(new PHUIIconView()) 394 + $expand_icon = id(new PHUIIconCircleView()) 395 395 ->addClass('phui-list-item-icon') 396 396 ->addClass('phui-profile-menu-visible-when-collapsed') 397 397 ->addSigil('has-tooltip')
+2 -2
src/applications/uiexample/examples/PHUIIconExample.php
··· 115 115 foreach ($circles as $circle) { 116 116 $circleview[] = 117 117 id(new PHUIIconCircleView()) 118 - ->setIcon($circle) 118 + ->setIconFont($circle) 119 119 ->setHref('#') 120 120 ->addClass('mmr'); 121 121 } ··· 124 124 foreach ($circles as $circle) { 125 125 $circleview[] = 126 126 id(new PHUIIconCircleView()) 127 - ->setIcon($circle) 127 + ->setIconFont($circle) 128 128 ->setSize(PHUIIconCircleView::MEDIUM) 129 129 ->setHref('#') 130 130 ->addClass('mmr');
+1 -1
src/view/phui/PHUIIconCircleView.php
··· 15 15 return $this; 16 16 } 17 17 18 - public function setIcon($icon) { 18 + public function setIconFont($icon) { 19 19 $this->icon = $icon; 20 20 return $this; 21 21 }
+2 -1
src/view/phui/PHUIListItemView.php
··· 160 160 return $this; 161 161 } 162 162 163 - public function addIcon(PHUIIconView $icon) { 163 + public function addIcon($icon) { 164 164 $this->icons[] = $icon; 165 165 return $this; 166 166 } ··· 275 275 if ($this->profileImage) { 276 276 $icon = id(new PHUIIconView()) 277 277 ->setHeadSize(PHUIIconView::HEAD_SMALL) 278 + ->addClass('phui-list-item-icon') 278 279 ->setImage($this->profileImage); 279 280 } 280 281
+38 -57
webroot/rsrc/css/phui/phui-profile-menu.css
··· 45 45 .phui-profile-menu .phabricator-side-menu .phui-list-item-href { 46 46 display: block; 47 47 text-decoration: none; 48 - padding: 12px 8px 12px 48px; 49 - font-size: 15px; 48 + padding: 0 8px 0 48px; 49 + height: 48px; 50 + font-size: {$biggerfontsize}; 50 51 -webkit-font-smoothing: antialiased; 51 52 color: {$menu.profile.text}; 52 53 line-height: 22px; 53 54 overflow: hidden; 54 55 text-overflow: ellipsis; 55 - 56 - /* NOTE: We must have an opaque background on these items so the footer 57 - items appear opaque when the render over normal items. */ 58 - background: {$menu.profile.background}; 56 + line-height: 48px; 59 57 } 60 58 61 59 .phui-profile-menu .phabricator-side-menu .phui-list-item-icon, 62 60 .phui-profile-menu .phabricator-side-menu 63 - .phui-list-item-href .phui-icon-view { 61 + .phui-list-item-href .phui-list-item-icon { 64 62 position: absolute; 65 63 top: 12px; 66 64 left: 13px; 67 - font-size: 20px; 68 - width: 22px; 69 - height: 22px; 70 - line-height: 22px; 65 + font-size: 24px; 66 + width: 24px; 67 + height: 24px; 68 + line-height: 24px; 71 69 text-align: center; 72 70 color: {$menu.profile.text}; 73 71 background-size: 100%; ··· 76 74 .phui-profile-menu .phui-profile-menu-collapsed .phabricator-side-menu 77 75 .phui-list-item-href { 78 76 text-align: center; 79 - padding: 42px 8px 12px; 80 - font-size: 11px; 81 - line-height: 13px; 77 + padding: 42px 4px 14px; 78 + line-height: 14px; 79 + height: auto; 80 + font-size: {$smallerfontsize}; 82 81 } 83 82 84 83 .phui-profile-menu .phui-profile-menu-collapsed .phabricator-side-menu ··· 91 90 .phui-profile-menu .phui-profile-menu-collapsed .phabricator-side-menu 92 91 .phui-list-item-icon, 93 92 .phui-profile-menu .phui-profile-menu-collapsed .phabricator-side-menu 94 - .phui-list-item-href .phui-icon-view { 95 - top: 10px; 96 - left: 29px; 93 + .phui-list-item-href .phui-list-item-icon { 94 + top: 14px; 95 + left: 31px; 97 96 } 98 97 99 98 .phui-profile-menu .phabricator-side-menu ··· 130 129 color: {$menu.profile.text.selected}; 131 130 } 132 131 133 - 134 132 .phui-profile-menu .phabricator-side-menu .phui-divider { 135 133 margin: 4px 0; 136 - border-bottom: 1px solid rgba(0, 0, 0, 0.200); 134 + border-bottom: 1px solid rgba(0, 0, 0, 0.2); 137 135 } 138 136 139 137 .phui-profile-menu .phabricator-side-menu .phui-motivator { ··· 154 152 height: {$menu.profile.item.height}; 155 153 } 156 154 157 - .phui-profile-menu .phabricator-side-menu .phui-profile-menu-footer { 158 - position: fixed; 159 - box-sizing: border-box; 160 - width: {$menu.profile.width}; 161 - bottom: 0px; 155 + .phui-profile-menu .phui-profile-menu-collapsed .phabricator-side-menu 156 + .phui-profile-menu-footer 157 + .phui-list-item-name { 158 + display: none; 162 159 } 163 160 164 - .phui-profile-menu .phabricator-side-menu .phui-profile-menu-footer-1 { 165 - left: 0; 161 + .phui-profile-menu .phui-profile-menu-expanded 162 + .phui-profile-menu-visible-when-collapsed, 163 + .phui-profile-menu .phui-profile-menu-collapsed 164 + .phui-profile-menu-visible-when-expanded { 165 + display: none; 166 166 } 167 167 168 - .phui-profile-menu .phabricator-side-menu .phui-profile-menu-footer-2 { 169 - left: 120px; 168 + .phui-profile-menu .phui-profile-menu-footer .phui-icon-circle { 169 + border-color: {$menu.profile.text}; 170 170 } 171 171 172 - .phui-profile-menu .phui-profile-menu-collapsed .phabricator-side-menu 173 - .phui-profile-menu-footer { 174 - width: 40px; 175 - height: {$menu.profile.item.height}; 176 - bottom: 0px; 172 + .phui-profile-menu .phui-profile-menu-footer .phui-icon-circle .phui-icon-view { 173 + color: {$menu.profile.text}; 177 174 } 178 175 179 - .phui-profile-menu .phui-profile-menu-collapsed .phabricator-side-menu 180 - .phui-profile-menu-footer-1 { 181 - left: 0; 176 + .phui-profile-menu .phui-profile-menu-footer:hover .phui-icon-circle { 177 + border-color: #fff; 182 178 } 183 179 184 - .phui-profile-menu .phui-profile-menu-collapsed .phabricator-side-menu 185 - .phui-profile-menu-footer-2 { 186 - left: 40px; 180 + .phui-profile-menu .phui-profile-menu-footer:hover .phui-icon-circle 181 + .phui-icon-view { 182 + color: #fff; 187 183 } 188 184 189 - .phui-profile-menu .phui-profile-menu-collapsed .phabricator-side-menu 190 - .phui-profile-menu-footer 191 - .phui-list-item-name { 192 - display: none; 193 - } 194 - 195 - .phui-profile-menu .phui-profile-menu-collapsed .phabricator-side-menu 196 - .phui-profile-menu-footer 197 - .phui-list-item-icon { 198 - top: 10px; 199 - left: 10px; 200 - } 201 - 202 - .phui-profile-menu .phui-profile-menu-expanded 203 - .phui-profile-menu-visible-when-collapsed, 204 - .phui-profile-menu .phui-profile-menu-collapsed 205 - .phui-profile-menu-visible-when-expanded { 206 - display: none; 185 + .phui-profile-menu .phui-profile-menu-footer 186 + .phui-icon-circle.phui-list-item-icon { 187 + font-size: 11px; 207 188 }
+1 -1
webroot/rsrc/css/phui/phui-workboard-view.css
··· 43 43 44 44 .device-desktop .phui-profile-menu-collapsed .project-board-wrapper 45 45 .phui-workboard-view-shadow { 46 - left: 93px; 46 + left: 101px; 47 47 } 48 48 49 49 .device-desktop .phui-workboard-view .aphront-multi-column-fixed