recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Default newPage() to device-ready

Summary:
Ref T9690. The "meta viewport" tag got dropped by accident because of the sort of weird logic on the old flow.

Make the default device-ready, then just turn it off for the tiny number of non-device pages.

Test Plan:
- Verified meta viewport tag appears on normal pages again.
- Verified it doesn't show up on non-mobile pages like Maniphest Reports.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9690

Differential Revision: https://secure.phabricator.com/D14396

authored by

epriestley and committed by
epriestley 6b194af6 0afccd20

+4 -3
+4 -3
src/applications/base/controller/PhabricatorController.php
··· 447 447 public function newPage() { 448 448 $page = id(new PhabricatorStandardPageView()) 449 449 ->setRequest($this->getRequest()) 450 - ->setController($this); 450 + ->setController($this) 451 + ->setDeviceReady(true); 451 452 452 453 $application = $this->getCurrentApplication(); 453 454 if ($application) { ··· 595 596 $page->setPageObjectPHIDs($object_phids); 596 597 } 597 598 598 - if (idx($options, 'device', true)) { 599 - $page->setDeviceReady(true); 599 + if (!idx($options, 'device', true)) { 600 + $page->setDeviceReady(false); 600 601 } 601 602 602 603 $page->setShowFooter(idx($options, 'showFooter', true));