@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix a JS issue when the anchor element on a page has no container
Summary: See D21213. If there's no matching element, `findAbove()` throws. Handle these cases correctly.
Test Plan: Visited `#toc` on a revision, no longer saw a JS error.
Differential Revision: https://secure.phabricator.com/D21222
+18
-10
+9
-9
resources/celerity/map.php
+9
-9
resources/celerity/map.php
···
10
10
'conpherence.pkg.css' => '0e3cf785',
11
11
'conpherence.pkg.js' => '020aebcf',
12
12
'core.pkg.css' => '1b80c45d',
13
-
'core.pkg.js' => '632fb8f5',
13
+
'core.pkg.js' => '1e667bcb',
14
14
'dark-console.pkg.js' => '187792c2',
15
15
'differential.pkg.css' => '2d70b7b9',
16
16
'differential.pkg.js' => '22ec6f26',
···
508
508
'rsrc/js/core/behavior-tokenizer.js' => '3b4899b0',
509
509
'rsrc/js/core/behavior-tooltip.js' => '73ecc1f8',
510
510
'rsrc/js/core/behavior-user-menu.js' => '60cd9241',
511
-
'rsrc/js/core/behavior-watch-anchor.js' => 'e55a1db5',
511
+
'rsrc/js/core/behavior-watch-anchor.js' => 'a77e2cbd',
512
512
'rsrc/js/core/behavior-workflow.js' => '9623adc1',
513
513
'rsrc/js/core/darkconsole/DarkLog.js' => '3b869402',
514
514
'rsrc/js/core/darkconsole/DarkMessage.js' => '26cd4b73',
···
658
658
'javelin-behavior-phabricator-tooltips' => '73ecc1f8',
659
659
'javelin-behavior-phabricator-transaction-comment-form' => '2bdadf1a',
660
660
'javelin-behavior-phabricator-transaction-list' => '9cec214e',
661
-
'javelin-behavior-phabricator-watch-anchor' => 'e55a1db5',
661
+
'javelin-behavior-phabricator-watch-anchor' => 'a77e2cbd',
662
662
'javelin-behavior-pholio-mock-edit' => '3eed1f2b',
663
663
'javelin-behavior-pholio-mock-view' => '5aa1544e',
664
664
'javelin-behavior-phui-dropdown-menu' => '5cf0501a',
···
1874
1874
'javelin-install',
1875
1875
'javelin-dom',
1876
1876
),
1877
+
'a77e2cbd' => array(
1878
+
'javelin-behavior',
1879
+
'javelin-stratcom',
1880
+
'javelin-dom',
1881
+
'javelin-vector',
1882
+
),
1877
1883
'a8f573a9' => array(
1878
1884
'javelin-install',
1879
1885
'javelin-dom',
···
2121
2127
'javelin-stratcom',
2122
2128
'javelin-dom',
2123
2129
'phuix-dropdown-menu',
2124
-
),
2125
-
'e55a1db5' => array(
2126
-
'javelin-behavior',
2127
-
'javelin-stratcom',
2128
-
'javelin-dom',
2129
-
'javelin-vector',
2130
2130
),
2131
2131
'e5bdb730' => array(
2132
2132
'javelin-behavior',
+9
-1
webroot/rsrc/js/core/behavior-watch-anchor.js
+9
-1
webroot/rsrc/js/core/behavior-watch-anchor.js
···
98
98
// If there's an "anchor-container" parent element, we'll make the
99
99
// display adjustment to that node instead. For example, this is used
100
100
// by the timeline to highlight timeline stories.
101
-
var container = JX.DOM.findAbove(node, null, 'anchor-container');
101
+
102
+
var container;
103
+
104
+
try {
105
+
container = JX.DOM.findAbove(node, null, 'anchor-container');
106
+
} catch (ex) {
107
+
// Ignore.
108
+
}
109
+
102
110
if (container) {
103
111
display_target = container;
104
112
} else {