@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix call to undefined method PhrictionDocumentTitleTransaction::renderHandleLink()

Summary:
`PhrictionDocumentTitleTransaction` calls `$this->renderHandleLink()`.
`PhabricatorApplicationTransaction` defines that method `public function renderHandleLink($phid)`.
PhrictionDocumentTitleTransaction extends PhrictionDocumentVersionTransaction extends PhrictionDocumentTransactionType extends PhabricatorModularTransactionType extends Phobject. No PhabricatorApplicationTransaction in that ancestor tree. Thus this call will fail.
Thus replace `renderHandleLink()` with `renderHandle()` which accepts a PHID as its parameter (credits to mainframe98 for finding out).

Test Plan: Unclear how to trigger via the UI, so run static code analysis and read/grep the code.

Reviewers: O1 Blessed Committers, mainframe98, valerio.bozzolan

Reviewed By: O1 Blessed Committers, mainframe98, valerio.bozzolan

Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Tags: #phriction

Differential Revision: https://we.phorge.it/D25752

+1 -1
+1 -1
src/applications/phriction/xaction/PhrictionDocumentTitleTransaction.php
··· 47 47 return pht( 48 48 '%s stubbed out this document when creating %s.', 49 49 $this->renderAuthor(), 50 - $this->renderHandleLink( 50 + $this->renderHandle( 51 51 $this->getMetadataValue('stub:create:phid'))); 52 52 } else { 53 53 return pht(