@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Change the Herald "do not include [any of]" condition label to "include none of"
Summary: Fixes T13445. Make the meaning of this condition more clear, since the current wording is ambiguous between "any of" and "all of".
Test Plan: Edited a Herald rule with a PHID list field ("Project tags"), saw text label say "include none of".
Maniphest Tasks: T13445
Differential Revision: https://secure.phabricator.com/D20889
+1
-1
+1
-1
src/applications/herald/adapter/HeraldAdapter.php
+1
-1
src/applications/herald/adapter/HeraldAdapter.php
···
399
399
self::CONDITION_IS_NOT_ANY => pht('is not any of'),
400
400
self::CONDITION_INCLUDE_ALL => pht('include all of'),
401
401
self::CONDITION_INCLUDE_ANY => pht('include any of'),
402
-
self::CONDITION_INCLUDE_NONE => pht('do not include'),
402
+
self::CONDITION_INCLUDE_NONE => pht('include none of'),
403
403
self::CONDITION_IS_ME => pht('is myself'),
404
404
self::CONDITION_IS_NOT_ME => pht('is not myself'),
405
405
self::CONDITION_REGEXP => pht('matches regexp'),