@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Allow users to add "ProfileMenu" items on mobile
Summary:
Depends on D20337. Fixes T12167. Ref T13272. On this page ("Favorites > Edit Favorites > Personal", for example) the curtain actions aren't available on mobile.
Normally, curtains are built with `Controller->newCurtainView()`, which sets an ID on the action list, which populates the header button. This curtain is built directly because there's no `Controller` handy.
To fix the issue, just set an ID. This could probably be cleaner, but that's likely a much more involved change.
Test Plan: Edited my favorites, narrowed the window, saw an "Actions" button.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T13272, T12167
Differential Revision: https://secure.phabricator.com/D20338
+4
-6
+4
-6
src/applications/search/engine/PhabricatorProfileMenuEngine.php
+4
-6
src/applications/search/engine/PhabricatorProfileMenuEngine.php
···
917
917
$list->addItem($view);
918
918
}
919
919
920
-
$action_view = id(new PhabricatorActionListView())
921
-
->setUser($viewer);
922
-
923
920
$item_types = PhabricatorProfileMenuItem::getAllMenuItems();
924
921
$object = $this->getProfileObject();
925
922
926
923
$action_list = id(new PhabricatorActionListView())
927
924
->setViewer($viewer);
925
+
926
+
// See T12167. This makes the "Actions" dropdown button show up in the
927
+
// page header.
928
+
$action_list->setID(celerity_generate_unique_node_id());
928
929
929
930
$action_list->addAction(
930
931
id(new PhabricatorActionView())
···
969
970
->setHeaderText(pht('Current Menu Items'))
970
971
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
971
972
->setObjectList($list);
972
-
973
-
$panel = id(new PHUICurtainPanelView())
974
-
->appendChild($action_view);
975
973
976
974
$curtain = id(new PHUICurtainView())
977
975
->setViewer($viewer)