recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Rename ACTION_ACCEPT into ACTION_ALLOW

Summary: Ref T603. This is "Allow" in the UI, I just mistyped it when I created the constant.

Test Plan: `grep`

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D7296

epriestley 6c1b00fa 3f5a7b31

+5 -5
+3 -3
src/applications/policy/__tests__/PhabricatorPolicyDataTestCase.php
··· 41 41 ->setRules( 42 42 array( 43 43 array( 44 - 'action' => PhabricatorPolicy::ACTION_ACCEPT, 44 + 'action' => PhabricatorPolicy::ACTION_ALLOW, 45 45 'rule' => 'PhabricatorPolicyRuleUsers', 46 46 'value' => array($user_a->getPHID()), 47 47 ), ··· 77 77 ->setRules( 78 78 array( 79 79 array( 80 - 'action' => PhabricatorPolicy::ACTION_ACCEPT, 80 + 'action' => PhabricatorPolicy::ACTION_ALLOW, 81 81 'rule' => 'PhabricatorPolicyRuleAdministrators', 82 82 'value' => null, 83 83 ), ··· 111 111 ->setRules( 112 112 array( 113 113 array( 114 - 'action' => PhabricatorPolicy::ACTION_ACCEPT, 114 + 'action' => PhabricatorPolicy::ACTION_ALLOW, 115 115 'rule' => 'PhabricatorPolicyRuleLunarPhase', 116 116 'value' => 'new', 117 117 ),
+1 -1
src/applications/policy/filter/PhabricatorPolicyFilter.php
··· 396 396 $action = $policy->getDefaultAction(); 397 397 } 398 398 399 - if ($action === PhabricatorPolicy::ACTION_ACCEPT) { 399 + if ($action === PhabricatorPolicy::ACTION_ALLOW) { 400 400 return true; 401 401 } 402 402
+1 -1
src/applications/policy/storage/PhabricatorPolicy.php
··· 3 3 final class PhabricatorPolicy 4 4 extends PhabricatorPolicyDAO { 5 5 6 - const ACTION_ACCEPT = 'accept'; 6 + const ACTION_ALLOW = 'allow'; 7 7 const ACTION_DENY = 'deny'; 8 8 9 9 private $name;