@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
User Profile Badges View: Wrap in a PHUIObjectBoxView for consistency
Summary:
All other views in the user profile do the same: Showing some header with blue-grey background to let the user know what they are looking at, not using a `PHUIInfoView` which looks like an inappropriate dialog design in this very place.
Closes T16212
Test Plan:
* Go to http://phorge.localhost/people/badges/1/ for a user with received badges
* Go to http://phorge.localhost/people/badges/2/ for a user without received badges
Reviewers: O1 Blessed Committers, mainframe98
Reviewed By: O1 Blessed Committers, mainframe98
Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Maniphest Tasks: T16212
Differential Revision: https://we.phorge.it/D26260
+9
-7
+9
-7
src/applications/people/controller/PhabricatorPeopleProfileBadgesController.php
+9
-7
src/applications/people/controller/PhabricatorPeopleProfileBadgesController.php
···
100
100
$flex->addItem($item);
101
101
}
102
102
} else {
103
-
$flex = id(new PHUIInfoView())
104
-
->setSeverity(PHUIInfoView::SEVERITY_NOTICE)
105
-
->appendChild(pht('User has not been awarded any badges.'));
103
+
$flex = id(new PHUIObjectItemListView())
104
+
->setNoDataString(pht('User has not been awarded any badges.'));
106
105
}
107
106
108
-
return array(
109
-
$flex,
110
-
$pager,
111
-
);
107
+
$view = id(new PHUIObjectBoxView())
108
+
->setHeaderText(pht('Received Badges'))
109
+
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
110
+
->appendChild($flex)
111
+
->appendChild($pager);
112
+
113
+
return $view;
112
114
}
113
115
}