@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Delete differential.updatetaskrevisionassoc
Summary: Used only by Facebook.
Test Plan: Moved to Facebook repo and verified it still works.
Reviewers: nh, epriestley
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D4515
-67
-2
src/__phutil_library_map__.php
-2
src/__phutil_library_map__.php
···
136
136
'ConduitAPI_differential_query_Method' => 'applications/differential/conduit/ConduitAPI_differential_query_Method.php',
137
137
'ConduitAPI_differential_setdiffproperty_Method' => 'applications/differential/conduit/ConduitAPI_differential_setdiffproperty_Method.php',
138
138
'ConduitAPI_differential_updaterevision_Method' => 'applications/differential/conduit/ConduitAPI_differential_updaterevision_Method.php',
139
-
'ConduitAPI_differential_updatetaskrevisionassoc_Method' => 'applications/differential/conduit/ConduitAPI_differential_updatetaskrevisionassoc_Method.php',
140
139
'ConduitAPI_differential_updateunitresults_Method' => 'applications/differential/conduit/ConduitAPI_differential_updateunitresults_Method.php',
141
140
'ConduitAPI_diffusion_findsymbols_Method' => 'applications/diffusion/conduit/ConduitAPI_diffusion_findsymbols_Method.php',
142
141
'ConduitAPI_diffusion_getcommits_Method' => 'applications/diffusion/conduit/ConduitAPI_diffusion_getcommits_Method.php',
···
1566
1565
'ConduitAPI_differential_query_Method' => 'ConduitAPIMethod',
1567
1566
'ConduitAPI_differential_setdiffproperty_Method' => 'ConduitAPIMethod',
1568
1567
'ConduitAPI_differential_updaterevision_Method' => 'ConduitAPIMethod',
1569
-
'ConduitAPI_differential_updatetaskrevisionassoc_Method' => 'ConduitAPIMethod',
1570
1568
'ConduitAPI_differential_updateunitresults_Method' => 'ConduitAPIMethod',
1571
1569
'ConduitAPI_diffusion_findsymbols_Method' => 'ConduitAPIMethod',
1572
1570
'ConduitAPI_diffusion_getcommits_Method' => 'ConduitAPIMethod',
-65
src/applications/differential/conduit/ConduitAPI_differential_updatetaskrevisionassoc_Method.php
-65
src/applications/differential/conduit/ConduitAPI_differential_updatetaskrevisionassoc_Method.php
···
1
-
<?php
2
-
3
-
/**
4
-
* @group conduit
5
-
*/
6
-
final class ConduitAPI_differential_updatetaskrevisionassoc_Method
7
-
extends ConduitAPIMethod {
8
-
9
-
public function getMethodStatus() {
10
-
return self::METHOD_STATUS_DEPRECATED;
11
-
}
12
-
13
-
public function getMethodStatusDescription() {
14
-
return "This method should not really exist. Pretend it doesn't.";
15
-
}
16
-
17
-
public function getMethodDescription() {
18
-
return "Given a task together with its original and new associated ".
19
-
"revisions, update the revisions for their attached_tasks.";
20
-
}
21
-
22
-
public function defineParamTypes() {
23
-
return array(
24
-
'task_phid' => 'required nonempty string',
25
-
'orig_rev_phids' => 'required list<string>',
26
-
'new_rev_phids' => 'required list<string>',
27
-
);
28
-
}
29
-
30
-
public function defineReturnType() {
31
-
return 'void';
32
-
}
33
-
34
-
public function defineErrorTypes() {
35
-
return array(
36
-
'ERR_NO_TASKATTACHER_DEFINED' => 'No task attacher defined.',
37
-
);
38
-
}
39
-
40
-
protected function execute(ConduitAPIRequest $request) {
41
-
$task_phid = $request->getValue('task_phid');
42
-
$orig_rev_phids = $request->getValue('orig_rev_phids');
43
-
if (empty($orig_rev_phids)) {
44
-
$orig_rev_phids = array();
45
-
}
46
-
47
-
$new_rev_phids = $request->getValue('new_rev_phids');
48
-
if (empty($new_rev_phids)) {
49
-
$new_rev_phids = array();
50
-
}
51
-
52
-
try {
53
-
$task_attacher = PhabricatorEnv::newObjectFromConfig(
54
-
'differential.attach-task-class');
55
-
$task_attacher->updateTaskRevisionAssoc(
56
-
$task_phid,
57
-
$orig_rev_phids,
58
-
$new_rev_phids);
59
-
} catch (ReflectionException $ex) {
60
-
throw new ConduitException('ERR_NO_TASKATTACHER_DEFINED');
61
-
}
62
-
}
63
-
64
-
}
65
-