recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Conpherence - fix a few bugs

Summary:
1) make the page title and uri update appropos to selected widget 2) make a behavior actually listen 3) fix the css so the button can always be clicked to edit metadata

Ref T3035 as I was trying to repro the metadata edit bug there and couldn't.

Test Plan: made the window small enought to have all the widgets visible and be in "device mode". noted page title and uri updated correctly from Conpherence and /conphernece/ to Thread Title and /conpherence/$id/ when toggling between thread list and current thread. made the window small enough to have the title and subtitle fields overlap with the edit button.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin, chad

Maniphest Tasks: T3035

Differential Revision: https://secure.phabricator.com/D5754

Bob Trahan 6c5d98bb 8872d5b6

+15 -12
+10 -10
webroot/rsrc/css/application/conpherence/header-pane.css
··· 37 37 } 38 38 39 39 .conpherence-header-pane .title { 40 - position: relative; 40 + position: absolute; 41 41 font-size: 16px; 42 42 font-weight: bold; 43 43 left: 77px; 44 44 top: 21px; 45 - max-width: 80%; 45 + right: 66px; 46 46 overflow-x: auto; 47 47 } 48 48 49 49 .conpherence-header-pane .custom-title { 50 - position: relative; 50 + position: absolute; 51 51 font-size: 16px; 52 52 font-weight: bold; 53 53 left: 132px; 54 54 top: 21px; 55 - max-width: 80%; 55 + right: 66px; 56 56 overflow-x: auto; 57 57 } 58 58 59 59 .conpherence-header-pane .subtitle { 60 - position: relative; 60 + position: absolute; 61 61 left: 77px; 62 - top: 21px; 62 + top: 40px; 63 + right: 66px; 63 64 color: #bfbfbf; 64 - max-width: 80%; 65 65 } 66 66 67 67 .conpherence-header-pane .custom-subtitle { 68 - position: relative; 68 + position: absolute; 69 69 left: 132px; 70 - top: 21px; 70 + top: 40px; 71 + right: 66px; 71 72 color: #bfbfbf; 72 - max-width: 80%; 73 73 } 74 74 75 75 .conpherence-header-pane .upload-photo {
+4 -1
webroot/rsrc/js/application/conpherence/behavior-menu.js
··· 61 61 JX.History.replace(config.base_uri + uri_suffix); 62 62 if (data.title) { 63 63 document.title = data.title; 64 + } else if (thread.node) { 65 + var threadData = JX.Stratcom.getData(thread.node); 66 + document.title = threadData.title; 64 67 } 65 68 } 66 69 ··· 173 176 } 174 177 175 178 JX.Stratcom.listen( 176 - null, 177 179 'conpherence-redraw-thread', 180 + null, 178 181 function (e) { 179 182 didredrawthread(); 180 183 }
+1 -1
webroot/rsrc/js/application/conpherence/behavior-widget-pane.js
··· 64 64 JX.Stratcom.invoke( 65 65 'conpherence-update-page-data', 66 66 null, 67 - { use_base_uri : true } 67 + { use_base_uri : true, title: 'Conpherence' } 68 68 ); 69 69 } 70 70 } else {