@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix accessing private parent class properties in QueryFuture
Summary:
PHPStan complains about `Access to private property $exception of parent class Future` and `Access to private property $result of parent class Future` in `QueryFuture`.
Thus call the corresponding public functions provided by `Future` instead.
Test Plan: Run static code analysis; read the code.
Reviewers: O1 Blessed Committers, valerio.bozzolan
Reviewed By: O1 Blessed Committers, valerio.bozzolan
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Differential Revision: https://we.phorge.it/D25755
+2
-2
+2
-2
src/infrastructure/storage/future/QueryFuture.php
+2
-2
src/infrastructure/storage/future/QueryFuture.php
···
51
51
}
52
52
53
53
public function isReady() {
54
-
if ($this->result !== null || $this->exception) {
54
+
if ($this->canResolve()) {
55
55
return true;
56
56
}
57
57
···
105
105
106
106
$this->processResults($this->conn->resolveAsyncQueries($conns, $asyncs));
107
107
108
-
if ($this->result !== null || $this->exception) {
108
+
if ($this->canResolve()) {
109
109
return true;
110
110
}
111
111
return false;