recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

PHP 8.5: Herald rule creation: Do not pass empty parameter keys

Summary:
Setting null as an array key is deprecated since PHP 8.5 per https://www.php.net/releases/8.5/en.php: "Using null as an array offset or when calling array_key_exists() is now deprecated. Use an empty string instead."

```
ERROR 8192: Using null as an array offset is deprecated, use an empty string instead at [/var/www/html/phorge/phorge/src/applications/herald/controller/HeraldNewController.php:11]
```

```
ERROR 8192: Using null as an array offset is deprecated, use an empty string instead at [/var/www/html/phorge/phorge/src/applications/herald/controller/HeraldNewController.php:20]
```

Closes T16364

Test Plan:
* Go to http://phorge.localhost/herald/create/
* Go to http://phorge.localhost/herald/create/?adapter=HeraldManiphestTaskAdapter

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16364

Differential Revision: https://we.phorge.it/D26535

Andre Klapper 6d98f6b3 32158162

+2 -2
+2 -2
src/applications/herald/controller/HeraldNewController.php
··· 8 8 $adapter_type_map = HeraldAdapter::getEnabledAdapterMap($viewer); 9 9 $adapter_type = $request->getStr('adapter'); 10 10 11 - if (!isset($adapter_type_map[$adapter_type])) { 11 + if (!$adapter_type || !isset($adapter_type_map[$adapter_type])) { 12 12 $title = pht('Create Herald Rule'); 13 13 $content = $this->newAdapterMenu($title); 14 14 } else { ··· 17 17 $rule_type_map = HeraldRuleTypeConfig::getRuleTypeMap(); 18 18 $rule_type = $request->getStr('type'); 19 19 20 - if (!isset($rule_type_map[$rule_type])) { 20 + if (!$rule_type || !isset($rule_type_map[$rule_type])) { 21 21 $title = pht( 22 22 'Create Herald Rule: %s', 23 23 $adapter->getAdapterContentName());