recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix an issue where storage inlines are fed to InlineAdjustmentEngine

Summary:
Ref T13513. If an intradiff has at least one unchanged file ("hasSameEffectAs()") or more than 100 files ("Large Change"), we hit this block and don't upcast storage inlines to runtime inlines. I missed this in testing.

Add the conversion step.

Test Plan: Viewed an intradiff with at least one unchanged file and at least one inline comment, saw correct rendering instead of fatal.

Maniphest Tasks: T13513

Differential Revision: https://secure.phabricator.com/D21239

epriestley 6dc20d1e e7ebd5d9

+2
+2
src/applications/differential/controller/DifferentialRevisionViewController.php
··· 234 234 ->withPublishedComments(true) 235 235 ->execute(); 236 236 237 + $inlines = mpull($inlines, 'newInlineCommentObject'); 238 + 237 239 $inlines = id(new PhabricatorInlineCommentAdjustmentEngine()) 238 240 ->setViewer($viewer) 239 241 ->setRevision($revision)