recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix a dashboard bucketing bug

Summary: Ref T10939. For various historical reasons, revision status is a numeric string. This comparison fails because it's `(string) !== (int)`. Just use `!=` so this will still work if we turn it into a real string in the future.

Test Plan: Tried a more specific test case locally, got better looking results in "Must Review" and "Should Review".

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10939

Differential Revision: https://secure.phabricator.com/D15928

epriestley 6e9828c7 8a98868b

+1 -1
+1 -1
src/applications/differential/query/DifferentialRevisionResultBucket.php
··· 17 17 18 18 $status_review = ArcanistDifferentialRevisionStatus::NEEDS_REVIEW; 19 19 foreach ($objects as $key => $object) { 20 - if ($object->getStatus() !== $status_review) { 20 + if ($object->getStatus() != $status_review) { 21 21 continue; 22 22 } 23 23