recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

PHP 8.5: PhabricatorUserLogView: Do not add missing actor PHID to array

Summary:
Setting null as an array key is deprecated since PHP 8.5 per https://www.php.net/releases/8.5/en.php: "Using null as an array offset or when calling array_key_exists() is now deprecated. Use an empty string instead."

```
ERROR 8192: Using null as an array offset is deprecated, use an empty string instead at [/var/www/html/phorge/phorge/src/applications/phid/handle/pool/PhabricatorHandlePool.php:29]
```

Closes T16403

Test Plan: Go to http://phorge.localhost/dashboard/panel/edit/?panelType=query and create a query panel with Search For = Account Activity; open the resulting panel

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16403

Differential Revision: https://we.phorge.it/D26599

Andre Klapper 6ea98dd8 6c37172a

+4 -1
+4 -1
src/applications/people/view/PhabricatorUserLogView.php
··· 25 25 26 26 $phids = array(); 27 27 foreach ($logs as $log) { 28 - $phids[] = $log->getActorPHID(); 28 + $actor_phid = $log->getActorPHID(); 29 + if ($actor_phid) { 30 + $phids[] = $actor_phid; 31 + } 29 32 $phids[] = $log->getUserPHID(); 30 33 } 31 34 $handles = $viewer->loadHandles($phids);