@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix quicksand interaction with HTTP GET prefilling in ApplicationSearch
Summary:
Fixes T10196. This is a weird interaction and this might not be the best long-term fix, but just get it working OK for now.
General problem is that Quicksand doesn't currently use GET for requests. This is a very unusual case where the method is relevant. In the future, I might change Quicksand to use GET.
Test Plan: Clicked "Open Tasks" with Quicksand active, got a results list.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10196
Differential Revision: https://secure.phabricator.com/D15082
+1
-1
+1
-1
src/applications/search/controller/PhabricatorApplicationSearchController.php
+1
-1
src/applications/search/controller/PhabricatorApplicationSearchController.php
···
100
100
} else if (!strlen($this->queryKey)) {
101
101
$found_query_data = false;
102
102
103
-
if ($request->isHTTPGet()) {
103
+
if ($request->isHTTPGet() || $request->isQuicksand()) {
104
104
// If this is a GET request and it has some query data, don't
105
105
// do anything unless it's only before= or after=. We'll build and
106
106
// execute a query from it below. This allows external tools to build