@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Unprototype the Ferret UI fields
Summary:
Ref T12819. Show the new Ferret engine fields (and enable the indexer) unconditionally.
Also pull them to the top since they're fairly general-purpose and appear more broadly now, and also they actually work correctly (WOW).
Some redundant fields (like "Name Contains" in Repositories and Owners) could probably be removed now, I may clean those up in a followup.
Test Plan: Browsed around, saw Ferret fields in UI without "(Prototype)" suffix.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T12819
Differential Revision: https://secure.phabricator.com/D18587
+5
-2
+3
src/applications/search/engine/PhabricatorApplicationSearchEngine.php
+3
src/applications/search/engine/PhabricatorApplicationSearchEngine.php
···
324
324
325
325
$result = $head + $body + $tail;
326
326
327
+
// Force the fulltext "query" field to the top unconditionally.
328
+
$result = array_select_keys($result, array('query')) + $result;
329
+
327
330
foreach ($this->getHiddenFields() as $hidden_key) {
328
331
unset($result[$hidden_key]);
329
332
}
+2
-2
src/applications/search/engineextension/PhabricatorFerretSearchEngineExtension.php
+2
-2
src/applications/search/engineextension/PhabricatorFerretSearchEngineExtension.php
···
6
6
const EXTENSIONKEY = 'ferret';
7
7
8
8
public function isExtensionEnabled() {
9
-
return PhabricatorEnv::getEnvConfig('phabricator.show-prototypes');
9
+
return true;
10
10
}
11
11
12
12
public function getExtensionName() {
···
56
56
57
57
$fields[] = id(new PhabricatorSearchTextField())
58
58
->setKey('query')
59
-
->setLabel(pht('Query (Prototype)'))
59
+
->setLabel(pht('Query'))
60
60
->setDescription(pht('Fulltext search.'));
61
61
62
62
return $fields;